[lldb] Add lldb team to CODEOWNERS #65454
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/orgs/llvm/teams/pr-subscribers-lldb exists but wasn't added to this file.
JDevlieghere
approved these changes
Sep 6, 2023
|
Looking at the diff page I see: Is that expected? It doesn't say this for any of the existing lines, maybe this team is configured incorrectly. |
DavidSpickett
force-pushed
the
lldb-code-owners
branch
from
5408750
to
86c6e51
Compare
|
The warning isn't shown for pr-subscribers-x86 so there's something different about the lldb team. |
I can't see any difference between @llvm/pr-subscribers-x86 and @llvm/pr-subscribers-lldb. I can confirm that @llvm/pr-subscribers-lldb exists and is publicly visible. @tstellar Could you have a look? You might see more than we can? Does the LLDB group have write access? |
tstellar
approved these changes
Sep 6, 2023
avillega
pushed a commit
to avillega/llvm-project
that referenced
this pull request
Sep 11, 2023
https://github.com/orgs/llvm/teams/pr-subscribers-lldb exists but wasn't added to this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/orgs/llvm/teams/pr-subscribers-lldb exists but wasn't added to this file.