Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[llvm] Adopt WithMarkup in the ARM backend #65561

Merged
merged 1 commit into from
Sep 12, 2023
Merged

[llvm] Adopt WithMarkup in the ARM backend #65561

merged 1 commit into from
Sep 12, 2023

Conversation

JDevlieghere
Copy link
Member

Adopt the new markup overload, introduced in 77d1032, in the ARM backend. This commit completes the migration and removes the old overload.

@JDevlieghere
[llvm] Adopt WithMarkup in the ARM backend
56b11a2 
Adopt the new markup overload, introduced in 77d1032, in the ARM
backend. This commit completes the migration and removes the old
overload.
@JDevlieghere JDevlieghere requested review from a team as code owners September 7, 2023 03:09
@github-actions github-actions bot added the mc Machine (object) code label Sep 7, 2023
@JDevlieghere JDevlieghere self-assigned this Sep 7, 2023
@JDevlieghere JDevlieghere mentioned this pull request Sep 12, 2023
Merged
@JDevlieghere
Copy link
Member Author

Friendly ping. This would complete the WithMarkup transition.

MaskRay
MaskRay approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@MaskRay MaskRay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skimmed through the changes. Looked good!

@JDevlieghere JDevlieghere merged commit da81b1b into llvm:main Sep 12, 2023
2 checks passed
@JDevlieghere JDevlieghere deleted the arm-markup branch September 12, 2023 22:14
@vzakhari vzakhari mentioned this pull request Sep 12, 2023
Closed
JDevlieghere added a commit to apple/llvm-project that referenced this pull request Sep 14, 2023
@JDevlieghere
[llvm] Adopt WithMarkup in the ARM backend (llvm#65561)
a99eb30 
Adopt the new markup overload, introduced in 77d1032, in the ARM
backend. This commit completes the migration and removes the old
overload.

(cherry picked from commit da81b1b)
ZijunZhaoCCK pushed a commit to ZijunZhaoCCK/llvm-project that referenced this pull request Sep 19, 2023
@JDevlieghere @ZijunZhaoCCK
[llvm] Adopt WithMarkup in the ARM backend (llvm#65561)
b863fe9 
Adopt the new markup overload, introduced in 77d1032, in the ARM
backend. This commit completes the migration and removes the old
overload.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaskRay MaskRay MaskRay approved these changes

Assignees

@JDevlieghere JDevlieghere

Labels
backend:ARM mc Machine (object) code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@JDevlieghere @MaskRay