Skip to content

[MC][RISCV] Add assembly syntax highlighting for RISCV #65853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 12, 2023
Merged

[MC][RISCV] Add assembly syntax highlighting for RISCV #65853

merged 4 commits into from
Sep 12, 2023

Conversation

dtcxzyw
Copy link
Member

@dtcxzyw dtcxzyw commented Sep 9, 2023

This patch adds support for syntax highlighting RISC-V assembly.
Related patch:
AArch64: https://reviews.llvm.org/D159162
X86: https://reviews.llvm.org/D159241

@dtcxzyw dtcxzyw requested a review from jh7370 September 9, 2023 17:48
@dtcxzyw dtcxzyw requested a review from a team as a code owner September 9, 2023 17:48
@llvmbot llvmbot added backend:RISC-V llvm:mc Machine (object) code labels Sep 9, 2023
jrtc27
jrtc27 reviewed Sep 9, 2023
View reviewed changes
jrtc27
jrtc27 reviewed Sep 9, 2023
View reviewed changes
@dtcxzyw dtcxzyw requested review from a team as code owners September 10, 2023 21:44
@dtcxzyw
Copy link
Member Author

dtcxzyw commented Sep 10, 2023

Sorry to bother you. I just forgot to rebase before pushing...

@llvm llvm deleted a comment from llvmbot Sep 10, 2023
@llvm llvm deleted a comment from llvmbot Sep 10, 2023
@llvm llvm deleted a comment from llvmbot Sep 10, 2023
@llvm llvm deleted a comment from llvmbot Sep 10, 2023
@llvm llvm deleted a comment from llvmbot Sep 10, 2023
@llvm llvm deleted a comment from llvmbot Sep 10, 2023
@llvm llvm deleted a comment from llvmbot Sep 10, 2023
jrtc27
jrtc27 reviewed Sep 10, 2023
View reviewed changes
jrtc27
jrtc27 reviewed Sep 10, 2023
View reviewed changes
@dtcxzyw dtcxzyw requested a review from a team September 10, 2023 22:12
@JDevlieghere JDevlieghere self-requested a review September 12, 2023 00:29
@JDevlieghere
Copy link
Member

Thank you for working on this!

JDevlieghere
JDevlieghere reviewed Sep 12, 2023
View reviewed changes
JDevlieghere
JDevlieghere approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@JDevlieghere JDevlieghere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might be worth having someone with more RISC-V ISA knowledge to sign off on this too before merging.

@dtcxzyw dtcxzyw merged commit 4e07262 into llvm:main Sep 12, 2023
@dtcxzyw dtcxzyw deleted the rv-colored-disas branch September 12, 2023 17:46
@vzakhari vzakhari mentioned this pull request Sep 12, 2023
Closed
@dtcxzyw dtcxzyw mentioned this pull request Sep 19, 2023
Merged
ZijunZhaoCCK pushed a commit to ZijunZhaoCCK/llvm-project that referenced this pull request Sep 19, 2023
@dtcxzyw @ZijunZhaoCCK
[MC][RISCV] Add assembly syntax highlighting for RISCV (llvm#65853)
0c713dd 
This patch adds support for syntax highlighting RISC-V assembly.
Related patch:
AArch64: https://reviews.llvm.org/D159162
X86: https://reviews.llvm.org/D159241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrtc27 jrtc27 jrtc27 left review comments

@MaskRay MaskRay MaskRay approved these changes

@JDevlieghere JDevlieghere JDevlieghere approved these changes

@jh7370 jh7370 Awaiting requested review from jh7370

Assignees
No one assigned
Labels
backend:RISC-V llvm:mc Machine (object) code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dtcxzyw @JDevlieghere @MaskRay @jrtc27 @llvmbot