[llvm][Docs] Show how to format Python files changed in a commit #66227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
black will always work on whole files and darker seems to be the only way to get it to work on chunks of files as you would with clang-format and https://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting. This adds a one liner for the common use case. In theory you can not list files and use `.` as the path instead but it seems to find all python files, then see if they have changed. Instead of starting with the change list. So it takes ages on llvm-project/.
|
We could just link to it however the example given on https://pypi.org/project/darker/ will take ages to run on llvm-project, for the reason noted in the commit message. |
|
I think this is a dupe of #66141 |
|
I'll just comment on the other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
black will always work on whole files and darker seems to be the only way to get it to work on chunks of files as you would with clang-format and https://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting.
This adds a one liner for the common use case. In theory you can not list files and use
.as the path instead but it seems to find all python files, then see if they have changed. Instead of starting with the change list. So it takes ages on llvm-project/.