[TableGen] Enhance !range bang operator #66489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangpc-pp
requested review from
chapuni,
darkbuck,
arsenm,
Paul-C-Anagnostopoulos and
nhaehnle
|
Ping. |
nhaehnle
reviewed
Sep 26, 2023
We add a third argument `step` to `!range` bang operator to make it with the same semantics as `range` in Python. `step` can be negative. `step` is 1 by default and `step` can't be 0. If `start` < `end` and `step` is negative, or `start` > `end` and `step` is positive, the result is an empty list.
Add more examples in doc
wangpc-pp
force-pushed
the
main-tablegen-enhance-range-operator
branch
from
e4bb68e
to
925c742
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
wangpc-pp
added a commit
to wangpc-pp/llvm-project
that referenced
this pull request
Sep 27, 2023
To simplify some code. This PR is stacked on llvm#66489.
legrosbuffle
pushed a commit
to legrosbuffle/llvm-project
that referenced
this pull request
Sep 29, 2023
We add a third argument `step` to `!range` bang operator to make it with the same semantics as `range` in Python. `step` can be negative. `step` is 1 by default and `step` can't be 0. If `start` < `end` and `step` is negative, or `start` > `end` and `step` is positive, the result is an empty list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We add a third argument
stepto!rangebang operator to make itwith the same semantics as
rangein Python.stepcan be negative.stepis 1 by default andstepcan't be0. If
start<endandstepis negative, orstart>endand
stepis positive, the result is an empty list.