[InstrProf] Correct buffer size for encodeULEB128 #67011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function uses 16 bytes buffer to encode two 64 bits data. However, the encoding method requires 10 bytes to encode one 64 bits data, so encoded data actually requiress 20 bytes total. I send a patch about this at https://bugs.llvm.org/show_bug.cgi?id=37447, but it is left as is. So I'm submitting the patch again. I personally recommend to remove encodeULEB128 with buffer version and use only encodeULEB128 with stream version.
petrhosek
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function uses 16 bytes buffer to encode two 64 bits data. However, the encoding method requires 10 bytes to encode one 64 bits data, so encoded data actually requiress 20 bytes total.
I send a patch about this at https://bugs.llvm.org/show_bug.cgi?id=37447, but it is left as is. So I'm submitting the patch again. I personally recommend to remove encodeULEB128 with buffer version and use only encodeULEB128 with stream version.