[BOLT][NFC] Run ADRRelaxationPass in parallel #67831
Conversation
To do this: 1. Protect BC.Ctx with mutex 2. Don't call exit from thread, please check the reason comment near PassFailed variable definition. The other option would be call _Exit instead of exit, but I think we shall call destructors properly.
yota9
force-pushed
the
run_adr_relax_in_parallel
branch
from
9374d24
to
7edc308
Compare
There was a problem hiding this comment.
LG, any wins in processing time from this change?
In general, we don't want to be unnecessarily running things in parallel because they significantly complicate debugging. But if we have good wins, go ahead and commit it. Also consider using a std::atomic_bool to flag it as a value that is accessed by multiple threads.
|
@rafaelauler To be honest I don't have big-enough binary right now to check. On a simple binary I see reduction from 3.3% user time to 0. Anyway we have most of the passes run in parallel, I don't think it is a big deal to run this one too.. As for atomic I just don't see reason to use it here, since we only set variable to true and we don't really care about racing conditions in such situation... Thanks for your reviews! |
Local branch amd-gfx ac6784f Merged main:fef1bec39642 into amd-gfx:b13841aa3970 Remote branch main f99bd29 [BOLT][NFC] Run ADRRelaxationPass in parallel (llvm#67831)
To do this:
PassFailed variable definition. The other option would be call _Exit
instead of exit, but I think we shall call destructors properly.