Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AArch64] Fix an incorrect handling of debug values in MachineSink #68107

Merged
merged 1 commit into from
Oct 4, 2023
Merged

[AArch64] Fix an incorrect handling of debug values in MachineSink #68107

merged 1 commit into from
Oct 4, 2023

Conversation

momchil-velikov
Copy link
Collaborator

No description provided.

davemgreen
davemgreen approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@davemgreen davemgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds OK to me

@momchil-velikov momchil-velikov merged commit b30765c into llvm:main Oct 4, 2023
3 of 4 checks passed
momchil-velikov added a commit that referenced this pull request Oct 6, 2023
@momchil-velikov
Re-apply "[AArch64] Enable "sink-and-fold" in MachineSink by default (#…
a9d0ab2 
…67432)"

This re-applies commit ace20e2, which was reverted in eff4ef2.

The issues were fixed in:

  * b30765c [AArch64] Fix an incorrect handling of debug values in
    MachineSink (#68107)

  * b454b04 [AArch64] Fix a compiler crash in MachineSink (#67705)
@momchil-velikov momchil-velikov deleted the sink-and-fold-hotfix branch October 13, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davemgreen davemgreen davemgreen approved these changes

@hassnaaHamdi hassnaaHamdi Awaiting requested review from hassnaaHamdi

@CarolineConcatto CarolineConcatto Awaiting requested review from CarolineConcatto

Assignees
No one assigned
Labels
backend:AArch64
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@momchil-velikov @davemgreen @llvmbot