Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Clang] Actually fix tests for __builtin_vectorelements #69589

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

lawben
Copy link
Contributor

@lawben lawben commented Oct 19, 2023

In #69582, I accidentally disabled all tests for the changed introduced in #69010. This change should use the correct REQUIRES syntax to en-/disable target-specific tests.

@llvmbot llvmbot added the clang Clang issues not falling into any other category label Oct 19, 2023
@lawben
Copy link
Contributor Author

lawben commented Oct 19, 2023

@nikic Could you please double-check if the syntax here is correct. After the mistake in #69582, I'm a bit nervous about merging a wrong fix again... 😅 On my machine, this seems to do the right thing, which the change in the previous PR did not.

@llvmbot
Copy link
Collaborator

llvmbot commented Oct 19, 2023

@llvm/pr-subscribers-clang

Author: Lawrence Benson (lawben)

Changes

In #69582, I accidentally disabled all tests for the changed introduced in #69010. This change should use the correct REQUIRES syntax to en-/disable target-specific tests.


Full diff: https://github.com/llvm/llvm-project/pull/69589.diff

2 Files Affected:

  • (modified) clang/test/CodeGen/builtin_vectorelements.c (+3-3)
  • (modified) clang/test/SemaCXX/builtin_vectorelements.cpp (+1-1)
diff --git a/clang/test/CodeGen/builtin_vectorelements.c b/clang/test/CodeGen/builtin_vectorelements.c
index 06d9ee7e056a83e..b0ff6f83b1e4adb 100644
--- a/clang/test/CodeGen/builtin_vectorelements.c
+++ b/clang/test/CodeGen/builtin_vectorelements.c
@@ -1,12 +1,12 @@
 // RUN: %clang_cc1 -O1 -triple x86_64                        %s -emit-llvm -disable-llvm-passes -o - | FileCheck --check-prefixes=CHECK       %s
 
-// REQUIRES: target=aarch64-{{.*}}
+// REQUIRES: aarch64-registered-target
 // RUN: %clang_cc1 -O1 -triple aarch64 -target-feature +neon %s -emit-llvm -disable-llvm-passes -o - | FileCheck --check-prefixes=CHECK,NEON  %s
 
-// REQUIRES: target=aarch64-{{.*}}
+// REQUIRES: aarch64-registered-target
 // RUN: %clang_cc1 -O1 -triple aarch64 -target-feature +sve  %s -emit-llvm -disable-llvm-passes -o - | FileCheck --check-prefixes=CHECK,SVE   %s
 
-// REQUIRES: target=riscv64{{.*}}
+// REQUIRES: riscv-registered-target
 // RUN: %clang_cc1 -O1 -triple riscv64 -target-feature +v    %s -emit-llvm -disable-llvm-passes -o - | FileCheck --check-prefixes=CHECK,RISCV %s
 
 /// Note that this does not make sense to check for x86 SIMD types, because
diff --git a/clang/test/SemaCXX/builtin_vectorelements.cpp b/clang/test/SemaCXX/builtin_vectorelements.cpp
index f40ba2a902cb5fc..59ff09ac72e42d7 100644
--- a/clang/test/SemaCXX/builtin_vectorelements.cpp
+++ b/clang/test/SemaCXX/builtin_vectorelements.cpp
@@ -1,6 +1,6 @@
 // RUN: %clang_cc1 -triple x86_64                       -std=c++20 -fsyntax-only -verify -disable-llvm-passes %s
 
-// REQUIRES: target=aarch64-{{.*}}
+// REQUIRES: aarch64-registered-target
 // RUN: %clang_cc1 -triple aarch64 -target-feature +sve -std=c++20 -fsyntax-only -verify -disable-llvm-passes %s
 
 template <typename T>

@lawben lawben merged commit 3d7802d into llvm:main Oct 19, 2023
4 checks passed
Guzhu-AMD pushed a commit to GPUOpen-Drivers/llvm-project that referenced this pull request Oct 26, 2023
Local branch amd-gfx 3573343 Merged main:202de4a5c6ed into amd-gfx:63f08b5fd01a
Remote branch main 3d7802d [Clang] Actually fix tests for __builtin_vectorelements (llvm#69589)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants