[Github] Add support for building libc docs in Github actions #69824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boomanaiden154
requested review from
tstellar,
sivachandra,
jhuber6 and
michaelrj-google
|
@llvm/pr-subscribers-github-workflow Author: Aiden Grossman (boomanaiden154) ChangesThis patch adds support for building the libc docs in Github actions. This eanbles easily diagnosing doc build failures/warnings in PRs and at the tip of tree. Full diff: https://github.com/llvm/llvm-project/pull/69824.diff 1 Files Affected:
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index 2900f73c77c5a66..aa82043e62eb561 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -15,10 +15,12 @@ on:
paths:
- 'llvm/docs/**'
- 'clang/docs/**'
+ - 'libc/docs/**'
pull_request:
paths:
- 'llvm/docs/**'
- 'clang/docs/**'
+ - 'libc/docs/**'
jobs:
check-docs-build:
@@ -47,6 +49,8 @@ jobs:
- 'llvm/docs/**'
clang:
- 'clang/docs/**'
+ libc:
+ - 'libc/docs/**'
- name: Setup Python env
uses: actions/setup-python@v4
with:
@@ -69,4 +73,10 @@ jobs:
run: |
cmake -B clang-build -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS="clang" -DLLVM_ENABLE_SPHINX=ON ./llvm
TZ=UTC ninja -C clang-build docs-clang-html docs-clang-man
+ - name: Build libc docs
+ if: steps.docs-changed-subprojects.outputs.libc_any_changed == 'true'
+ run: |
+ cmake -B libc-build -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_RUNTIMES="libc" -DLLVM_ENABLE_SPHINX=ON ./runtimes
+ TZ=UTC ninja -C libc-build docs-libc-html
+
|
This patch adds support for building the libc docs in Github actions. This eanbles easily diagnosing doc build failures/warnings in PRs and at the tip of tree.
boomanaiden154
force-pushed
the
libc-docs-ci
branch
from
1ae2875
to
c587685
Compare
jsji
added a commit
that referenced
this pull request
Oct 26, 2023
#69824 added libc build, but missed the folder in ninja command, is causing failures. ninja: fatal: chdir to 'docs-libc-html' - No such file or directory ninja: Entering directory `docs-libc-html'
jsji
added a commit
to intel/llvm
that referenced
this pull request
Oct 26, 2023
llvm/llvm-project#69824 added libc build, but missed the folder in ninja command, is causing failures. ninja: fatal: chdir to 'docs-libc-html' - No such file or directory ninja: Entering directory `docs-libc-html'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for building the libc docs in Github actions. This eanbles easily diagnosing doc build failures/warnings in PRs and at the tip of tree.