Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Github] Fix libc docs build #70363

Merged
merged 1 commit into from Oct 26, 2023
Merged

[Github] Fix libc docs build #70363

merged 1 commit into from Oct 26, 2023

Conversation

jsji
Copy link
Member

@jsji jsji commented Oct 26, 2023

#69824 added libc build, but missed the folder in ninja command
, is causing failures.

ninja: fatal: chdir to 'docs-libc-html' - No such file or directory
ninja: Entering directory `docs-libc-html'

       folder, causing failures.

ninja: fatal: chdir to 'docs-libc-html' - No such file or directory
ninja: Entering directory `docs-libc-html'
@llvmbot
Copy link
Collaborator

llvmbot commented Oct 26, 2023

@llvm/pr-subscribers-github-workflow

Author: Jinsong Ji (jsji)

Changes
   folder, causing failures.

ninja: fatal: chdir to 'docs-libc-html' - No such file or directory
ninja: Entering directory `docs-libc-html'


Full diff: https://github.com/llvm/llvm-project/pull/70363.diff

1 Files Affected:

  • (modified) .github/workflows/docs.yml (+1-1)
diff --git a/.github/workflows/docs.yml b/.github/workflows/docs.yml
index cbb3706cc1bcfec..e6af2f41167e0a1 100644
--- a/.github/workflows/docs.yml
+++ b/.github/workflows/docs.yml
@@ -119,7 +119,7 @@ jobs:
         if: steps.docs-changed-subprojects.outputs.libc_any_changed == 'true'
         run: |
           cmake -B libc-build -GNinja -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_RUNTIMES="libc" -DLLVM_ENABLE_SPHINX=ON ./runtimes
-          TZ=UTC ninja -C docs-libc-html
+          TZ=UTC ninja -C libc-build docs-libc-html
       - name: Build LLD docs
         if: steps.docs-changed-subprojects.outputs.lld_any_changed == 'true'
         run: |

Copy link
Contributor

@michaelrj-google michaelrj-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsji jsji merged commit cf07904 into llvm:main Oct 26, 2023
4 checks passed
@boomanaiden154
Copy link
Contributor

Thanks for the fix! Sorry for the breakage here. I must've completely missed the -C when I was looking at minimizing the target list. 😅

@michaelrj-google
Copy link
Contributor

All good, I think it's my fault for telling you that you didn't need "libc-build" because I misread the command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants