Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[lldb][lldb-server] Enable sending RegisterFlags as XML #69951

Merged
merged 6 commits into from
Oct 26, 2023
Merged

[lldb][lldb-server] Enable sending RegisterFlags as XML #69951

merged 6 commits into from
Oct 26, 2023

Commits on Oct 23, 2023

  1. [lldb][lldb-server] Enable sending registerflags as XML 

    This adds ToXML methods to encode RegisterFlags and its fields
into XML according to GDB's target XML format:
https://sourceware.org/gdb/onlinedocs/gdb/Target-Description-Format.html#Target-Description-Format

lldb-server does not currently use libXML to build XML,
so this follows the existing code that uses strings. Indentation
is used so the result is still human readable.

```
<flags id=\"Foo\" size=\"4\">
  <field name=\"abc\" start=\"0\" end=\"0\"/>
</flags>
```

This is used by lldb-server when building target XML,
though no one sets any fields yet. That'll come in a later commit.
    @DavidSpickett
    DavidSpickett committed Oct 23, 2023
    Configuration menu
    Copy the full SHA
    5c8b953 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2023

  1. Forward declare some things, add missing standard includes as a result.

    @DavidSpickett
    DavidSpickett committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    0efbe8f View commit details
    Browse the repository at this point in the history

  2. Single line if.

    @DavidSpickett
    DavidSpickett committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    9260233 View commit details
    Browse the repository at this point in the history

  3. Escape/replace reserved XML characters in field names.

    @DavidSpickett
    DavidSpickett committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    846a701 View commit details
    Browse the repository at this point in the history

  4. Fix docs typo.

    @DavidSpickett
    DavidSpickett committed Oct 24, 2023
    Configuration menu
    Copy the full SHA
    94ea66d View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2023

  1. Move assert into cpp

    @DavidSpickett
    DavidSpickett committed Oct 25, 2023
    Configuration menu
    Copy the full SHA
    46193c8 View commit details
    Browse the repository at this point in the history