[flang][OpenMP] Add semantic check for target update #71305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shraiysh
requested review from
kiranchandramohan,
raghavendhra,
agozillon,
dpalermo and
NimishMishra
llvmbot
added
flang
|
@llvm/pr-subscribers-flang-openmp Author: Shraiysh (shraiysh) ChangesThis patch adds the following semantic check for target update construct. Full diff: https://github.com/llvm/llvm-project/pull/71305.diff 2 Files Affected:
diff --git a/flang/lib/Semantics/check-omp-structure.cpp b/flang/lib/Semantics/check-omp-structure.cpp
index a328424e0c098d0..9f8af2217e47be2 100644
--- a/flang/lib/Semantics/check-omp-structure.cpp
+++ b/flang/lib/Semantics/check-omp-structure.cpp
@@ -1401,6 +1401,20 @@ void OmpStructureChecker::CheckTargetUpdate() {
context_.Say(GetContext().directiveSource,
"At least one motion-clause (TO/FROM) must be specified on TARGET UPDATE construct."_err_en_US);
}
+ if (toClause && fromClause) {
+ SymbolSourceMap toSymbols, fromSymbols;
+ GetSymbolsInObjectList(
+ std::get<parser::OmpClause::To>(toClause->u).v, toSymbols);
+ GetSymbolsInObjectList(
+ std::get<parser::OmpClause::From>(fromClause->u).v, fromSymbols);
+ for (auto &[symbol, source] : toSymbols) {
+ if (fromSymbols.find(symbol) != fromSymbols.end()) {
+ context_.Say(source,
+ "Symbol '%s': A list item can only appear in a to or from clause, but not in both."_err_en_US,
+ symbol->name());
+ }
+ }
+ }
}
void OmpStructureChecker::Enter(
diff --git a/flang/test/Semantics/OpenMP/target-update01.f90 b/flang/test/Semantics/OpenMP/target-update01.f90
index a0728e52ba3d230..f77d3f248df6a0a 100644
--- a/flang/test/Semantics/OpenMP/target-update01.f90
+++ b/flang/test/Semantics/OpenMP/target-update01.f90
@@ -13,4 +13,7 @@ subroutine foo(x)
!ERROR: At most one NOWAIT clause can appear on the TARGET UPDATE directive
!$omp target update to(x) nowait nowait
+ !ERROR: Symbol 'x': A list item can only appear in a to or from clause, but not in both.
+ !$omp target update to(x) from(x)
+
end subroutine
|
|
@llvm/pr-subscribers-flang-semantics Author: Shraiysh (shraiysh) ChangesThis patch adds the following semantic check for target update construct. Full diff: https://github.com/llvm/llvm-project/pull/71305.diff 2 Files Affected:
diff --git a/flang/lib/Semantics/check-omp-structure.cpp b/flang/lib/Semantics/check-omp-structure.cpp
index a328424e0c098d0..9f8af2217e47be2 100644
--- a/flang/lib/Semantics/check-omp-structure.cpp
+++ b/flang/lib/Semantics/check-omp-structure.cpp
@@ -1401,6 +1401,20 @@ void OmpStructureChecker::CheckTargetUpdate() {
context_.Say(GetContext().directiveSource,
"At least one motion-clause (TO/FROM) must be specified on TARGET UPDATE construct."_err_en_US);
}
+ if (toClause && fromClause) {
+ SymbolSourceMap toSymbols, fromSymbols;
+ GetSymbolsInObjectList(
+ std::get<parser::OmpClause::To>(toClause->u).v, toSymbols);
+ GetSymbolsInObjectList(
+ std::get<parser::OmpClause::From>(fromClause->u).v, fromSymbols);
+ for (auto &[symbol, source] : toSymbols) {
+ if (fromSymbols.find(symbol) != fromSymbols.end()) {
+ context_.Say(source,
+ "Symbol '%s': A list item can only appear in a to or from clause, but not in both."_err_en_US,
+ symbol->name());
+ }
+ }
+ }
}
void OmpStructureChecker::Enter(
diff --git a/flang/test/Semantics/OpenMP/target-update01.f90 b/flang/test/Semantics/OpenMP/target-update01.f90
index a0728e52ba3d230..f77d3f248df6a0a 100644
--- a/flang/test/Semantics/OpenMP/target-update01.f90
+++ b/flang/test/Semantics/OpenMP/target-update01.f90
@@ -13,4 +13,7 @@ subroutine foo(x)
!ERROR: At most one NOWAIT clause can appear on the TARGET UPDATE directive
!$omp target update to(x) nowait nowait
+ !ERROR: Symbol 'x': A list item can only appear in a to or from clause, but not in both.
+ !$omp target update to(x) from(x)
+
end subroutine
|
| for (auto &[symbol, source] : toSymbols) { | ||
| if (fromSymbols.find(symbol) != fromSymbols.end()) { | ||
| context_.Say(source, | ||
| "Symbol '%s': A list item can only appear in a to or from clause, but not in both."_err_en_US, |
There was a problem hiding this comment.
Nit: We have the clause name in caps usually.
Symbol is an internal concept. Might be better to phrase in terms of what the standard says.
Would it be possible to highlight both occurrences?
This patch adds the following semantic check for target update construct. ``` A list item can only appear in a to or from clause, but not in both. ```
shraiysh
force-pushed
the
target_update2
branch
from
fd9fb7b
to
eb2f737
Compare
This was referenced Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the following semantic check for target update construct.