[builtins] Guard the divtc3_test.c test with CRT_HAS_TF_MODE #71876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bots on https://green.lab.llvm.org/green/job/clang-stage1-RA/ were failing this test.
arichardson
reviewed
Nov 10, 2023
|
I think it's something to do with the clang version on the bot being older by a few years. I'm not entirely sure, can this go in anyway since we need to get it back to green? |
I'm happy for this to be merged, but could you file an issue that the feature detection is broken? |
|
This patch broke the Solaris/sparcv9 bot, which unfortunately was completely ignored: Issue #71971 lacks detail to decide if the workaround patch is correct. I suspect one could simply remove the |
zahiraam
pushed a commit
to zahiraam/llvm-project
that referenced
this pull request
Nov 20, 2023
) The bots on https://green.lab.llvm.org/green/job/clang-stage1-RA/ were failing this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bots on https://green.lab.llvm.org/green/job/clang-stage1-RA/ were
failing this test.