[BOLT] Fix C++ exceptions when LPStart is specified #72737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever LPStartEncoding was different from DW_EH_PE_omit, we used to miscalculate LPStart. As a result, landing pads were assigned wrong addresses. Fix that.
|
The new test failed in pre-merge checks. |
|
Yes. But passing locally… |
ayermolo
reviewed
Nov 19, 2023
|
|
||
| # Test case compiled from: | ||
| # | ||
| # int main() { |
There was a problem hiding this comment.
what was the build command to produce main code and exception table?
There was a problem hiding this comment.
clang++ input.cpp -o output.s -S
| if (LPOffset) { | ||
| if (LandingPad) { | ||
| // Verify if landing pad code is located outside current function | ||
| // Support landing pad to builtin_unreachable |
There was a problem hiding this comment.
If you mean the comment, it's moved from a different code location.
|
FYI: the reason the test is failing is unrelated to exceptions or the changes. Will post a separate PR. |
|
Rebuilt the test case with |
aaupov
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever LPStartEncoding was different from DW_EH_PE_omit, we used to miscalculate LPStart. As a result, landing pads were assigned wrong addresses. Fix that.