[BOLT] Refactor SplitFunctions for function reuse. NFC. #73078
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this PR is 2/8 for upstreaming a new 3-way (hot-warm-cold) function splitting algorithm CDSplit. |
ShatianWang
force-pushed
the
112123Commit2_SplitFunctionsReuse
branch
from
273ee29
to
61de295
Compare
This commit updates SplitFunctions.h and SplitFunctions.cpp to enable the reuse of createEHTrampolines, mergeEHTrampolines, hasFullProfile, and allBlocksCold by a distinct function splitting pass (CDSplit).
ShatianWang
force-pushed
the
112123Commit2_SplitFunctionsReuse
branch
from
61de295
to
4d47f05
Compare
ShatianWang
changed the title
|
Based on offline discussion with @maksfb, made the following changes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates SplitFunctions.h and SplitFunctions.cpp to enable
the reuse of createEHTrampolines, mergeEHTrampolines, allBlocksCold
by a distinct function splitting pass (CDSplit). While the SplitFunctions
pass happens before the function reordering pass because function
reordering depends on the function splitting decisions, CDSplit will be
implemented as a separate function splitting pass and called after the
function reordering pass to make use of the fixed function ordering to
achieve better function splitting decisions.