Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BOLT] Setup CDSplit Pass Structure #73079

Closed

Conversation

ShatianWang
Copy link
Contributor

This commit establishes the general structure of the CDSplit
implementation without incorporating the exact splitting logic.
Currently, all functions undergo hot-cold splitting based on the
decisions made by the SplitFunctions pass. Subsequent commits
will introduce the precise splitting logic.

@ShatianWang ShatianWang marked this pull request as ready for review November 22, 2023 04:41
@ShatianWang
Copy link
Contributor Author

Note: this PR is 3/8 for upstreaming a new 3-way (hot-warm-cold) function splitting algorithm CDSplit.
It is one commit ahead of #73078

This commit modifies BinaryContext::calculateEmittedSize to update the
BinaryBasicBlock::OutputAddressRange for each basic block in the input
BF. The modification is done in place, where BB.OutputAddressRange.second
less BB.OutputAddressRange.first now gives the emitted size of the basic
block.
This commit updates SplitFunctions.h and SplitFunctions.cpp to enable
the reuse of createEHTrampolines, mergeEHTrampolines, hasFullProfile,
and allBlocksCold by a distinct function splitting pass (CDSplit).
This commit establishes the general structure of the CDSplit
implementation without incorporating the exact splitting logic.
Currently, all functions undergo hot-cold splitting based on the
decisions made by the SplitFunctions pass. Subsequent commits
will introduce the precise splitting logic.
@ShatianWang ShatianWang force-pushed the 112123Commit3_SetupCDSplitStructure branch from 2215673 to 57ed132 Compare November 22, 2023 17:11
@ShatianWang ShatianWang marked this pull request as draft November 23, 2023 20:40
@ShatianWang ShatianWang deleted the 112123Commit3_SetupCDSplitStructure branch December 21, 2023 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant