[BOLT][test] Replace /dev/null with temp file #73485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaupov
added a commit
to aaupov/bolt-tests
that referenced
this pull request
Nov 27, 2023
NFC processing time script identifies tests by output filename. When `/dev/null` is used as output filename, we're unable to tell the source test, and the reports are unhelpful, e.g.: https://lab.llvm.org/buildbot/#/builders/244/builds/20918 Replace `/dev/null/ with `%t.null` which resolves the issue. Follow-up to llvm/llvm-project#73485
NFC processing time script identifies tests by output filename. When `/dev/null` is used as output filename, we're unable to tell the source test, and the reports are unhelpful. Replace `/dev/null/` with `%t.null` which resolves the issue.
mtvec
approved these changes
Nov 27, 2023
aaupov
added a commit
to rafaelauler/bolt-tests
that referenced
this pull request
Nov 27, 2023
NFC processing time script identifies tests by output filename. When `/dev/null` is used as output filename, we're unable to tell the source test, and the reports are unhelpful, e.g.: https://lab.llvm.org/buildbot/#/builders/244/builds/20918 Replace `/dev/null/ with `%t.null` which resolves the issue. Follow-up to llvm/llvm-project#73485
Guzhu-AMD
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Nov 30, 2023
Local branch amd-gfx e65d689 Merged main:d8b8aa3a5661 into amd-gfx:064a5f8331d7 Remote branch main ab14eb2 [BOLT][test] Replace /dev/null with temp file (llvm#73485)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NFC processing time script identifies tests by output filename.
When
/dev/nullis used as output filename, we're unable to tell thesource test, and the reports are unhelpful.
Replace
/dev/null/ with%t.null` which resolves the issue.