Commits on Dec 1, 2023

1. [TargetInstrInfo] update INLINEASM memoperands once …

   In commit b053359 ("[X86InstrInfo] support memfold on spillable inline asm
   (llvm#70832)"), I had a last minute fix to update the memoperands.  I originally
   did this in the parent foldInlineAsmMemOperand call, updated the mir test via
   update_mir_test_checks.py, but then decided to move it to the child call of
   foldInlineAsmMemOperand.
   
   But I forgot to rerun update_mir_test_checks.py. That last minute change caused
   the same memoperand to be added twice when recursion occurred (for tied
   operands). I happened to get lucky that trailing content omitted from the
   CHECK line doesn't result in test failure.
   
   But rerunning update_mir_test_checks.py on the mir test added in that commit
   produces updated output. This is resulting in updates to the test that:
   1. conflate additions to the test in child commits with simply updating the
      test as it should have been when first committed.
   2. look wrong because the same memoperand is specified twice (we don't
      deduplicate memoperands when added). Example:
   
       INLINEASM ... :: (load (s32) from %stack.0) (load (s32) from %stack.0)
   
   Fix the bug, so that in child commits, we don't have additional unrelated test
   changes (which would be wrong anyways) from simply running
   update_mir_test_checks.py.
   
   Link: llvm#20571

   

   nickdesaulniers committed Dec 1, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 6a30b60
   • Browse repository at this point

   Copy the full SHA

   6a30b60 View commit details

   Browse the repository at this point in the history

2. git clang-format HEAD~

   

   nickdesaulniers committed Dec 1, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for ae650b4
   • Browse repository at this point

   Copy the full SHA

   ae650b4 View commit details

   Browse the repository at this point in the history