[PowerPC] make LR/LR8 CTR/CTR8 aliased #76926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenzheng1030
requested review from
bzEq,
ecnelises,
nemanjai,
lei137 and
stefanp-ibm
bzEq
reviewed
Jan 4, 2024
| @@ -270,12 +270,15 @@ def CR7 : CR<7, "cr7", [CR7LT, CR7GT, CR7EQ, CR7UN]>, DwarfRegNum<[75, 75]>; | |||
|
|
|||
| // Link register | |||
| def LR : SPR<8, "lr">, DwarfRegNum<[-2, 65]>; | |||
| //let Aliases = [LR] in | |||
There was a problem hiding this comment.
Do you know why it was commented out?
There was a problem hiding this comment.
see 44dbdbe5cf5e
I guess it is because Aliases was not a member of Register at that time.
bzEq
approved these changes
Jan 5, 2024
justinfargnoli
pushed a commit
to justinfargnoli/llvm-project
that referenced
this pull request
Jan 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #47156
fixes #47155