Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libcxx] Require qemu-system-arm for armv7m builder #77067

Merged
merged 1 commit into from Jan 8, 2024

Commits on Jan 5, 2024

  1. [libcxx] Require qemu-system-arm for armv7m builder

    And add a check in the python script that the binary given to
    `--qemu` actually exists. Otherwise you get a generic Python error:
    ```
     # .---command stderr------------
     # | Traceback (most recent call last):
     # |   File "/home/david.spickett/modules-llvm-project/libcxx/utils/qemu_baremetal.py", line 70, in <module>
     # |     exit(main())
     # |   File "/home/david.spickett/modules-llvm-project/libcxx/utils/qemu_baremetal.py", line 66, in main
     # |     os.execvp(qemu_commandline[0], qemu_commandline)
     # |   File "/usr/lib/python3.8/os.py", line 568, in execvp
     # |     _execvpe(file, args)
     # |   File "/usr/lib/python3.8/os.py", line 610, in _execvpe
     # |     raise last_exc
     # |   File "/usr/lib/python3.8/os.py", line 601, in _execvpe
     # |     exec_func(fullname, *argrest)
     # | FileNotFoundError: [Errno 2] No such file or directory
     # `-----------------------------
     # error: command failed with exit status: 1
    ```
    When it tries to run the entire command later.
    
    For the builder, it's only ever going to use qemu-system-arm
    so error at config time if it's not there.
    DavidSpickett committed Jan 5, 2024
    Configuration menu
    Copy the full SHA
    9ac26d8 View commit details
    Browse the repository at this point in the history