[libc] Include missing RISC-V stdlib.h and math.h entrypoints #79034
Conversation
|
@llvm/pr-subscribers-libc Author: Petr Hosek (petrhosek) ChangesThis matches the entrypoints for baremetal ARM. Full diff: https://github.com/llvm/llvm-project/pull/79034.diff 1 Files Affected:
diff --git a/libc/config/baremetal/riscv/entrypoints.txt b/libc/config/baremetal/riscv/entrypoints.txt
index 5da755170fda96e..f725b1c2394c6a3 100644
--- a/libc/config/baremetal/riscv/entrypoints.txt
+++ b/libc/config/baremetal/riscv/entrypoints.txt
@@ -77,6 +77,7 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.stdlib.abort
libc.src.stdlib.abs
libc.src.stdlib.atoi
+ libc.src.stdlib.atof
libc.src.stdlib.atol
libc.src.stdlib.atoll
libc.src.stdlib.bsearch
@@ -86,7 +87,10 @@ set(TARGET_LIBC_ENTRYPOINTS
libc.src.stdlib.llabs
libc.src.stdlib.lldiv
libc.src.stdlib.qsort
+ libc.src.stdlib.strtod
+ libc.src.stdlib.strtof
libc.src.stdlib.strtol
+ libc.src.stdlib.strtold
libc.src.stdlib.strtoll
libc.src.stdlib.strtoul
libc.src.stdlib.strtoull
@@ -110,18 +114,124 @@ set(TARGET_LIBM_ENTRYPOINTS
libc.src.fenv.feupdateenv
# math.h entrypoints
+ libc.src.math.acosf
+ libc.src.math.acoshf
+ libc.src.math.asinf
+ libc.src.math.asinhf
+ libc.src.math.atanf
+ libc.src.math.atanhf
+ libc.src.math.ceil
+ libc.src.math.ceilf
+ libc.src.math.ceill
+ libc.src.math.copysign
+ libc.src.math.copysignf
+ libc.src.math.copysignl
+ libc.src.math.cosf
+ libc.src.math.coshf
+ libc.src.math.erff
+ libc.src.math.exp
+ libc.src.math.exp10
+ libc.src.math.exp10f
+ libc.src.math.exp2
+ libc.src.math.exp2f
+ libc.src.math.expf
+ libc.src.math.expm1
+ libc.src.math.expm1f
libc.src.math.fabs
libc.src.math.fabsf
libc.src.math.fabsl
libc.src.math.fdim
libc.src.math.fdimf
libc.src.math.fdiml
+ libc.src.math.floor
+ libc.src.math.floorf
+ libc.src.math.floorl
+ libc.src.math.fma
+ libc.src.math.fmaf
libc.src.math.fmax
libc.src.math.fmaxf
libc.src.math.fmaxl
libc.src.math.fmin
libc.src.math.fminf
libc.src.math.fminl
+ libc.src.math.fmod
+ libc.src.math.fmodf
+ libc.src.math.frexp
+ libc.src.math.frexpf
+ libc.src.math.frexpl
+ libc.src.math.hypot
+ libc.src.math.hypotf
+ libc.src.math.ilogb
+ libc.src.math.ilogbf
+ libc.src.math.ilogbl
+ libc.src.math.ldexp
+ libc.src.math.ldexpf
+ libc.src.math.ldexpl
+ libc.src.math.llrint
+ libc.src.math.llrintf
+ libc.src.math.llrintl
+ libc.src.math.llround
+ libc.src.math.llroundf
+ libc.src.math.llroundl
+ libc.src.math.log
+ libc.src.math.log10
+ libc.src.math.log10f
+ libc.src.math.log1p
+ libc.src.math.log1pf
+ libc.src.math.log2
+ libc.src.math.log2f
+ libc.src.math.logb
+ libc.src.math.logbf
+ libc.src.math.logbl
+ libc.src.math.logf
+ libc.src.math.lrint
+ libc.src.math.lrintf
+ libc.src.math.lrintl
+ libc.src.math.lround
+ libc.src.math.lroundf
+ libc.src.math.lroundl
+ libc.src.math.modf
+ libc.src.math.modff
+ libc.src.math.modfl
+ libc.src.math.nan
+ libc.src.math.nanf
+ libc.src.math.nanl
+ libc.src.math.nearbyint
+ libc.src.math.nearbyintf
+ libc.src.math.nearbyintl
+ libc.src.math.nextafter
+ libc.src.math.nextafterf
+ libc.src.math.nextafterl
+ libc.src.math.nexttoward
+ libc.src.math.nexttowardf
+ libc.src.math.nexttowardl
+ libc.src.math.powf
+ libc.src.math.remainder
+ libc.src.math.remainderf
+ libc.src.math.remainderl
+ libc.src.math.remquo
+ libc.src.math.remquof
+ libc.src.math.remquol
+ libc.src.math.rint
+ libc.src.math.rintf
+ libc.src.math.rintl
+ libc.src.math.round
+ libc.src.math.roundf
+ libc.src.math.roundl
+ libc.src.math.scalbn
+ libc.src.math.scalbnf
+ libc.src.math.scalbnl
+ libc.src.math.sincosf
+ libc.src.math.sinf
+ libc.src.math.sinhf
+ libc.src.math.sqrt
+ libc.src.math.sqrtf
+ libc.src.math.sqrtl
+ libc.src.math.tanf
+ libc.src.math.tanhf
+ libc.src.math.trunc
+ libc.src.math.truncf
+ libc.src.math.truncl
)
set(TARGET_LLVMLIBC_ENTRYPOINTS
|
This matches the entrypoints for baremetal ARM.
petrhosek
force-pushed
the
libc-riscv-baremetal-entrypoints
branch
from
bf421fc
to
03f7ad2
Compare
Done.
No, we currently have a bit of a chicken-and-egg problem where we need these targets to build the SDK which we need to run unit tests on the target. |
no worries, we also don't have a riscv32 buildbot set up yet, so we will be reliant on the results of your testing for now. We appreciate it (and need to consider more how to remedy the lack of buildbots for that target). Please send any fixups necessary (or file bugs). |
| +--------------+---------+---------+---------+---------+---------+---------+---------+---------+---------+---------+---------+---------+ | ||
| | truncl | |check| | |check| | |check| | |check| | |check| | | | |check| | |check| | | | | | ||
| | truncl | |check| | |check| | |check| | |check| | |check| | | | |check| | |check| | |check| | | | | ||
| +--------------+---------+---------+---------+---------+---------+---------+---------+---------+---------+---------+---------+---------+ | ||
|
|
||
|
|
There was a problem hiding this comment.
I can't comment below, but please update the second table in this file, too (below)!
There was a problem hiding this comment.
Done, sorry about that I missed it earlier.
We do have a rv32 buildbot on staging: https://lab.llvm.org/staging/#/builders/149 but it seems to be broken since the werror patch I think the current error is that |
Oh, interesting! What's staging and why do we have that there? https://lab.llvm.org/buildbot/#/builders?tags=libc is the dashboard I'm usually looking at, and that has an rv32 build bot that seems offline. |
This matches the entrypoints for baremetal ARM.