[Release] Build default target during Phase 1 and 2 on AIX #81009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+531
to
+532
| # compiler-rt builtins is needed on AIX to have a functional Phase 1 clang. | ||
| if [ "$Phase" -lt "3" ] && [ "$System" != "AIX" ]; then |
There was a problem hiding this comment.
This is insulating AIX from the broader effects of the code here (to reduce the phase 1 and 2 builds) entirely. It should be possible to just add the necessary additional targets for AIX.
There was a problem hiding this comment.
Yes, this is more of a temporary solution for now since I'm still not sure why the original code is skipping the compiler-rt build during phase 1. Once I've investigated the problem more I'll update the fix.
|
New PR: #81485 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit
fcae8cseems to be skipping the compiler-rt build during Phase 1 which results in a non-functional Phase 1 clang on AIX