[BOLT][NFC] Return Error from BinaryFunctionPass::runOnFunctions #81521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.4
aaupov
requested review from
maksfb,
rafaelauler,
ayermolo and
dcci
as code owners
rafaelauler
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Thanks, Amir. As commit message I think we can put something like:
As part of the effort to refactor old error handling code that
would directly call exit(1), in this patch we change the
interface to BinaryFunctionPass to return an Error on
runOnFunctions(). This gives passes the ability to report a
serious problem to the caller (RewriteInstance class), so the
caller may decide how to best handle the exceptional situation.
aaupov
deleted the
users/aaupov/spr/boltnfc-return-error-from-binaryfunctionpassrunonfunctions-2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the effort to refactor old error handling code that
would directly call exit(1), in this patch we change the
interface to
BinaryFunctionPassto return an Error onrunOnFunctions(). This gives passes the ability to report aserious problem to the caller (RewriteInstance class), so the
caller may decide how to best handle the exceptional situation.
Co-authored-by: Rafael Auler rafaelauler@fb.com
Test Plan: NFC