Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flang][docs] Update llvm-test-suite docs #81596

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

DavidSpickett
Copy link
Collaborator

@DavidSpickett DavidSpickett commented Feb 13, 2024

With some missing config options and a link to the test suite docs that explain how to setup ISO_FORTRAN_C_HEADER and set the stop message variable.

With some missing config options and the need to install,
which I always forget.
@llvmbot llvmbot added the flang Flang issues not falling into any other category label Feb 13, 2024
@DavidSpickett
Copy link
Collaborator Author

The header file is in the build tree, but flang doesn't find it:

$ find -name ISO_Fortran_binding.h
./lib/clang/19/include/ISO_Fortran_binding.h

Is that expected?

@kiranchandramohan
Copy link
Contributor

ISO_Fortran_binding.h

I think the requirement in general is that the C compiler can find it.

For the gfortran tests in LLVM testsuite there is a CMake Flag to provide the location
(-DTEST_SUITE_FORTRAN_ISO_C_HEADER_DIR).
https://github.com/llvm/llvm-test-suite/blob/main/Fortran/gfortran/README.md

@DavidSpickett
Copy link
Collaborator Author

Thanks, maybe it's better to link to that page then since it's already got these changes. I'll look into that.

@DavidSpickett
Copy link
Collaborator Author

Added a link to the test suite docs. We could remove the content here entirely but there is some value in having a basic intro on this page I think.

@DavidSpickett DavidSpickett merged commit d31406b into llvm:main Feb 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants