-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "[clang] Remove #undef alloca workaround" #81649
Conversation
This reverts commit 742a06f.
@llvm/pr-subscribers-clang Author: Prabhuk (Prabhuk) ChangesReverts llvm/llvm-project#81534 llvm/llvm-project#81534 breaks building (Fuchsia) Clang toolchain on Windows. Log: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8756186536543250705/+/u/clang/install/stdout
Full diff: https://github.com/llvm/llvm-project/pull/81649.diff 1 Files Affected:
diff --git a/clang/include/clang/Basic/Builtins.h b/clang/include/clang/Basic/Builtins.h
index 6700d1903a0088..f955d21169556a 100644
--- a/clang/include/clang/Basic/Builtins.h
+++ b/clang/include/clang/Basic/Builtins.h
@@ -20,6 +20,10 @@
#include "llvm/ADT/StringRef.h"
#include <cstring>
+// VC++ defines 'alloca' as an object-like macro, which interferes with our
+// builtins.
+#undef alloca
+
namespace clang {
class TargetInfo;
class IdentifierTable;
|
for my information, which version of Visual Studio are you using? |
We don't use MSVC. CC: @zeroomega |
To be precise, we don't use (not installed) full Visual Studio. We directly install Visual Studio build tools from VS2022. |
Reverts #81534
#81534 breaks building (Fuchsia) Clang toolchain on Windows.
Log: https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8756186536543250705/+/u/clang/install/stdout
Builder: https://ci.chromium.org/ui/p/fuchsia/builders/toolchain.ci/clang-windows-x64/b8756186536543250705/overview