[MC/DC] Introduce class TestVector with a pair of BitVector
#82174
Conversation
This replaces `SmallVector<CondState>` and emulates it. - True False DontCare (Impossible) - Values: True False False True - Visited: True True False False `findIndependencePairs()` can be optimized with logical ops. FIXME: Specialize `findIndependencePairs()` for the single word.
| BitVector Visited; /// ~DontCare | ||
|
|
||
| public: | ||
| /// Assume filling DontCare. |
There was a problem hiding this comment.
Why do you need to pass Cond when it is not being used?
There was a problem hiding this comment.
It's because the only user (TV in findExecutedTestVectors()) specifies DontCare explicitly. I wanted to leave it since I thought it was more descriptive.
I can prune the initial value in this.
| } | ||
|
|
||
| /// Emulate RHS SmallVector::operator[] | ||
| MCDCRecord::CondState operator[](int I) const { |
There was a problem hiding this comment.
Can you expand on this comment?
E.g.
For the condition at index \p I:
\returns MCDC_True when the condition has been visited
\returns MCDC_False when a condition has not been visited
\returns MCDC_DontCare when the condition does not impact MC/DC coverage
There was a problem hiding this comment.
I think they might be redundant to explain here since this handles the enum.
| /// Equivalent to buildTestVector's Index. | ||
| auto getIndex() const { return Values.getData()[0]; } | ||
|
|
||
| /// Emulate LHS SmallVector::operator[]. |
There was a problem hiding this comment.
Comment could be like
Set the condition at position \p I's CondState to \p Val.
There was a problem hiding this comment.
I would like to wait for both @MaskRay and @evodius96 , since they are authors of the current impl.
| BitVector Visited; /// ~DontCare | ||
|
|
||
| public: | ||
| /// Assume filling DontCare. |
There was a problem hiding this comment.
It's because the only user (TV in findExecutedTestVectors()) specifies DontCare explicitly. I wanted to leave it since I thought it was more descriptive.
I can prune the initial value in this.
| } | ||
|
|
||
| /// Emulate RHS SmallVector::operator[] | ||
| MCDCRecord::CondState operator[](int I) const { |
There was a problem hiding this comment.
I think they might be redundant to explain here since this handles the enum.
| if (!A.isDifferentOutcome(B)) | ||
| continue; |
There was a problem hiding this comment.
This could be eliminated.
| IndependencePairs.insert({Flip, std::make_pair(J + 1, I + 1)}); | ||
| auto AB = A.getDifferences(B); | ||
| assert(AB[NumConditions] && "The last element should be different"); | ||
| if (AB.count() == 2) // The single condition and the last element |
There was a problem hiding this comment.
This could be == 1 aka has_single_bit.
This replaces
SmallVector<CondState>and emulates it.findIndependencePairs()can be optimized with logical ops.FIXME: Specialize
findIndependencePairs()for the single word.