[MC/DC] Refactor: Isolate the final result out of TestVector #82282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chapuni
changed the title
chapuni
changed the title
|
I supposed this is the draft for opinion at first time, but I think it better to land in advance of #82174 , to clarify its effect (bitcount expected equal to 1). |
ornata
reviewed
Feb 26, 2024
| @@ -258,6 +258,12 @@ class MCDCRecordProcessor { | |||
| /// ExecutedTestVectorBitmap. | |||
| MCDCRecord::TestVectors ExecVectors; | |||
|
|
|||
| /// Temporary use | |||
There was a problem hiding this comment.
Can you expand on this comment a little?
There was a problem hiding this comment.
I've modified for ExecVectorsByCond[0] as the storage of the final ExecVectors.
ornata
approved these changes
Feb 27, 2024
chapuni
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reduce conditional judges in the loop in
findIndependencePairs(), I have tried a couple of tweaks.TestVectorsusing TestVectors = llvm::SmallVector<std::pair<TestVector, CondState>>;The final result was just piggybacked on
TestVector, so it has been isolated.ExecVectorsby the final resultIt will cost more in constructing
ExecVectors, but it can reduce at least one conditional judgement in the loop.