Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add scmp and ucmp to SelectionDAG.cpp #84681

Closed
wants to merge 49 commits into from

Conversation

miguelraz
Copy link
Contributor

@miguelraz miguelraz commented Mar 10, 2024

This is a PR based on #83227 that tries to add the scmp and ucmp new intrinsics to SelectionDAG.cpp .

cc @nikic

Copy link

github-actions bot commented Mar 10, 2024

⚠️ C/C++ code formatter, clang-format found issues in your code. ⚠️

You can test this locally with the following command:
git-clang-format --diff 7c460c6205eedaa24f77d5de272dfd94dc3e9a38 cf90dbaf2cf67d9cba5404977fd2f04cb2bebd75 -- llvm/include/llvm/CodeGen/ISDOpcodes.h llvm/include/llvm/CodeGen/TargetLowering.h llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp llvm/lib/IR/Verifier.cpp llvm/unittests/Analysis/ValueTrackingTest.cpp
View the diff from clang-format here.
diff --git a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
index 5b6ac8d1e3..1460a4cbd7 100644
--- a/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/SelectionDAG.cpp
@@ -6753,9 +6753,9 @@ SDValue SelectionDAG::getNode(unsigned Opcode, const SDLoc &DL, EVT VT,
   case ISD::UCMP:
   case ISD::SCMP:
     assert(VT.isInteger() && "This operator does not apply to FP types!");
-    assert(N1.getValueType() == N2.getValueType() && 
-           N1.getValueType() == VT && "Binary operator types must match");
-      break;
+    assert(N1.getValueType() == N2.getValueType() && N1.getValueType() == VT &&
+           "Binary operator types must match");
+    break;
   case ISD::FADD:
   case ISD::FSUB:
   case ISD::FMUL:

@miguelraz miguelraz changed the title Scmp and ucmp add scmp and ucmp to SelectionDAG.cpp Mar 10, 2024
miguelraz and others added 27 commits March 15, 2024 20:37
Co-authored-by: Nikita Popov <github@npopov.com>
Co-authored-by: Nikita Popov <github@npopov.com>
Co-authored-by: Nikita Popov <github@npopov.com>
Co-authored-by: Nikita Popov <github@npopov.com>
Co-authored-by: Nikita Popov <github@npopov.com>
Co-authored-by: Nikita Popov <github@npopov.com>
Co-authored-by: scottmcm <scottmcm@users.noreply.github.com>
Co-authored-by: scottmcm <scottmcm@users.noreply.github.com>
miguelraz and others added 22 commits March 15, 2024 20:37
Co-authored-by: Nikita Popov <github@npopov.com>
Co-authored-by: Nikita Popov <github@npopov.com>
Co-authored-by: Nikita Popov <github@npopov.com>
Co-authored-by: Nikita Popov <github@npopov.com>
Fixes the `sanitizer-x86_64-linux-android` buildbot.
…e… (llvm#85140)

Unrevert commit
llvm@2f67dfb
as there were already dependent changes in the codebase that now fail.
@miguelraz
Copy link
Contributor Author

Closing due to too many git headaches and restarting on fresh main with #85822

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants