Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[clang] Remove unused lambda capture. #83550

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

labrinea
Copy link
Collaborator

@labrinea labrinea commented Mar 1, 2024

Fixes the sanitizer-x86_64-linux-android buildbot.

Fixes the `sanitizer-x86_64-linux-android` buildbot.
@labrinea labrinea requested a review from jroelofs March 1, 2024 10:04
@llvmbot llvmbot added clang Clang issues not falling into any other category backend:AArch64 clang:codegen labels Mar 1, 2024
@llvmbot
Copy link

llvmbot commented Mar 1, 2024

@llvm/pr-subscribers-clang-codegen

Author: Alexandros Lamprineas (labrinea)

Changes

Fixes the sanitizer-x86_64-linux-android buildbot.


Full diff: https://github.com/llvm/llvm-project/pull/83550.diff

1 Files Affected:

  • (modified) clang/lib/CodeGen/Targets/AArch64.cpp (+1-2)
diff --git a/clang/lib/CodeGen/Targets/AArch64.cpp b/clang/lib/CodeGen/Targets/AArch64.cpp
index 79a9c1d5978a14..725e8a70fddfe6 100644
--- a/clang/lib/CodeGen/Targets/AArch64.cpp
+++ b/clang/lib/CodeGen/Targets/AArch64.cpp
@@ -882,8 +882,7 @@ void AArch64ABIInfo::appendAttributeMangling(StringRef AttrStr,
   for (auto &Feat : Features)
     Feat = Feat.trim();
 
-  const TargetInfo &TI = CGT.getTarget();
-  llvm::sort(Features, [&TI](const StringRef LHS, const StringRef RHS) {
+  llvm::sort(Features, [](const StringRef LHS, const StringRef RHS) {
     return LHS.compare(RHS) < 0;
   });
 

@llvmbot
Copy link

llvmbot commented Mar 1, 2024

@llvm/pr-subscribers-clang

Author: Alexandros Lamprineas (labrinea)

Changes

Fixes the sanitizer-x86_64-linux-android buildbot.


Full diff: https://github.com/llvm/llvm-project/pull/83550.diff

1 Files Affected:

  • (modified) clang/lib/CodeGen/Targets/AArch64.cpp (+1-2)
diff --git a/clang/lib/CodeGen/Targets/AArch64.cpp b/clang/lib/CodeGen/Targets/AArch64.cpp
index 79a9c1d5978a14..725e8a70fddfe6 100644
--- a/clang/lib/CodeGen/Targets/AArch64.cpp
+++ b/clang/lib/CodeGen/Targets/AArch64.cpp
@@ -882,8 +882,7 @@ void AArch64ABIInfo::appendAttributeMangling(StringRef AttrStr,
   for (auto &Feat : Features)
     Feat = Feat.trim();
 
-  const TargetInfo &TI = CGT.getTarget();
-  llvm::sort(Features, [&TI](const StringRef LHS, const StringRef RHS) {
+  llvm::sort(Features, [](const StringRef LHS, const StringRef RHS) {
     return LHS.compare(RHS) < 0;
   });
 

@llvmbot
Copy link

llvmbot commented Mar 1, 2024

@llvm/pr-subscribers-backend-aarch64

Author: Alexandros Lamprineas (labrinea)

Changes

Fixes the sanitizer-x86_64-linux-android buildbot.


Full diff: https://github.com/llvm/llvm-project/pull/83550.diff

1 Files Affected:

  • (modified) clang/lib/CodeGen/Targets/AArch64.cpp (+1-2)
diff --git a/clang/lib/CodeGen/Targets/AArch64.cpp b/clang/lib/CodeGen/Targets/AArch64.cpp
index 79a9c1d5978a14..725e8a70fddfe6 100644
--- a/clang/lib/CodeGen/Targets/AArch64.cpp
+++ b/clang/lib/CodeGen/Targets/AArch64.cpp
@@ -882,8 +882,7 @@ void AArch64ABIInfo::appendAttributeMangling(StringRef AttrStr,
   for (auto &Feat : Features)
     Feat = Feat.trim();
 
-  const TargetInfo &TI = CGT.getTarget();
-  llvm::sort(Features, [&TI](const StringRef LHS, const StringRef RHS) {
+  llvm::sort(Features, [](const StringRef LHS, const StringRef RHS) {
     return LHS.compare(RHS) < 0;
   });
 

@labrinea labrinea requested a review from nikic March 1, 2024 10:11
@labrinea
Copy link
Collaborator Author

labrinea commented Mar 1, 2024

Thanks for the quick respose!

@labrinea labrinea merged commit 8511b32 into llvm:main Mar 1, 2024
8 checks passed
@labrinea labrinea deleted the fix-unused-lambda-capture branch March 1, 2024 10:58
miguelraz pushed a commit to miguelraz/llvm-project that referenced this pull request Mar 16, 2024
Fixes the `sanitizer-x86_64-linux-android` buildbot.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend:AArch64 clang:codegen clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants