[flang] Do not create .f18.mod files for each compiled module #85249
Conversation
|
@kiranchandramohan @banach-space Ping :-) |
There was a problem hiding this comment.
Would the flang-to-external-fc script (https://flang.llvm.org/docs/FlangDriver.html#the-flang-to-external-fc-script) work without this? The script might not be needed if nobody is using it. If so it might be good to remove that in a separate patch.
Co-authored-by: Kiran Chandramohan <kiranchandramohan@gmail.com>
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
✅ With the latest revision this PR passed the Python code formatter. |
There was a problem hiding this comment.
LG, thanks!
Would the flang-to-external-fc script (https://flang.llvm.org/docs/FlangDriver.html#the-flang-to-external-fc-script) work without this? The script might not be needed if nobody is using it. If so it might be good to remove that in a separate patch.
+1 to removing it, but it would be good to ask on Discourse first
It seems like the `flang-to-external-fc` tool is no longer needed, because Flang is now a full compiler in its own right. After PR #85249 has landed, this tool will not be able to pick up the `.f18.mod` files.
It seems like the `flang-to-external-fc` tool is no longer needed, because Flang is now a full compiler in its own right. After PR llvm#85249 has landed, this tool will not be able to pick up the `.f18.mod` files.
The default CMake scripts had a copy operation to copy a compiled
.modfile to also be available with suffix.f18.mod. This seems no longer needed. Also updated ModFiles.md to point to-module-suffix.