-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[flang] Remove obsolete flang-to-external-fc tool #88904
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@sscalpone - any objections?
I have not seen any feedback for my post at https://discourse.llvm.org/t/flang-is-flang-to-external-fc-still-needed/78289. I guess, we can remove the tool and see if we get complaints? |
SGTM 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable. The RFC has been up for a week and this was raised on the community call earlier this week.
Plus, the removal of the f18.mod files has been merged a good while ago and nobody seems to have noticed. So, I'll go ahead and merge tomorrow to provide another window for objections. |
It seems like the `flang-to-external-fc` tool is no longer needed, because Flang is now a full compiler in its own right. After PR llvm#85249 has landed, this tool will not be able to pick up the `.f18.mod` files.
It seems like the
flang-to-external-fc
tool is no longer needed, because Flang is now a full compiler in its own right. After PR #85249 has landed, this tool will not be able to pick up the.f18.mod
files.