[Bitcode][Asm] Parse metadata value from operand bundles #87570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created using spr 1.3.6-beta.1
Prabhuk
pushed a commit
to Prabhuk/llvm-project
that referenced
this pull request
Apr 19, 2024
Support parsing operand bundles with metadata value from LLVM IR. This is almost an NFC since there is no existing producers/consumers for metadata operand bundle values, except the following call graph section patches in revision: Producer: https://reviews.llvm.org/D105909?id=358327 Consumer: https://reviews.llvm.org/D105915?id=358335 The test in this revision only ensures that the parser does not complain. The above-mentioned patches implicity test if passed metadata value is correct. Reviewed By: morehouse Differential Revision: https://reviews.llvm.org/D107038?id=362649 Pull Request: llvm#87570
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
ilovepi
reviewed
Apr 30, 2024
Comment on lines
+3143
to
+3144
| // compiled to bitcode, then disassembled back to LLVM IR. See PR#89649 | ||
| // for the reproducers, and https://bugs.llvm.org/show_bug.cgi?id=51264 |
There was a problem hiding this comment.
Suggested change
| // compiled to bitcode, then disassembled back to LLVM IR. See PR#89649 | |
| // for the reproducers, and https://bugs.llvm.org/show_bug.cgi?id=51264 | |
| // compiled to bitcode, then disassembled back to LLVM IR. | |
| // See [PR#89649](https://github.com/llvm/llvm-project/pull/89649) | |
| // for the reproducers, and https://github.com/llvm/llvm-project/issues/50608 |
I think URLs are better here, since developers can use them directly. The old bugzilla bug also has been migrated to github, so I think its better to use that link.
There was a problem hiding this comment.
I don't think it makes sense to only add support for one half of this... If we add IR parsing support, then bitcode writing should also work.
ilovepi
reviewed
Apr 30, 2024
| @@ -0,0 +1,9 @@ | |||
| ; This test ensures that we parse metadata operand bundle values. | |||
| ; RUN: llvm-as < %s | |||
There was a problem hiding this comment.
No CHECK lines? is this just a test that llvm-as doesn't crash?
Created using spr 1.3.6-beta.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support parsing operand bundles with metadata value from LLVM IR.
This is almost an NFC since there is no existing producers/consumers for
metadata operand bundle values, except the following call graph section
patches in revision:
Producer: https://reviews.llvm.org/D105909?id=358327
Consumer: https://reviews.llvm.org/D105915?id=358335
The test in this revision only ensures that the parser does not
complain. The above-mentioned patches implicity test if passed metadata
value is correct.