Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bitcode][Asm] Parse metadata value from operand bundles #87570

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[Bitcode][Asm] Parse metadata value from operand bundles #87570

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ca67025
[𝘀𝗽𝗿] initial version
necipfazil Apr 3, 2024
8d214f0
Updated fixme
necipfazil Apr 22, 2024
0ced778
Rebased PR on top of upstream main.
necipfazil Apr 24, 2024
b6c6bea
Rebased on top of main
necipfazil Apr 24, 2024
8d78f3f
Rebased on upstream main
necipfazil May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions llvm/lib/AsmParser/LLParser.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3135,9 +3135,21 @@ bool LLParser::parseOptionalOperandBundles(
return true;

Type *Ty = nullptr;
Value *Input = nullptr;
if (parseType(Ty) || parseValue(Ty, Input, PFS))
if (parseType(Ty))
return true;

Value *Input = nullptr;
// FIXME: Metadata operand bundle value is garbage when LLVM IR is
// compiled to bitcode, then disassembled back to LLVM IR. See PR#89649
// for the reproducers, and https://bugs.llvm.org/show_bug.cgi?id=51264
Comment on lines +3143 to +3144
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// compiled to bitcode, then disassembled back to LLVM IR. See PR#89649
// for the reproducers, and https://bugs.llvm.org/show_bug.cgi?id=51264
// compiled to bitcode, then disassembled back to LLVM IR.
// See [PR#89649](https://github.com/llvm/llvm-project/pull/89649)
// for the reproducers, and https://github.com/llvm/llvm-project/issues/50608

I think URLs are better here, since developers can use them directly. The old bugzilla bug also has been migrated to github, so I think its better to use that link.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it makes sense to only add support for one half of this... If we add IR parsing support, then bitcode writing should also work.

// for the bug report.
if (Ty->isMetadataTy()) {
if (parseMetadataAsValue(Input, PFS))
return true;
} else {
if (parseValue(Ty, Input, PFS))
return true;
}
Inputs.push_back(Input);
}

Expand Down
9 changes: 9 additions & 0 deletions llvm/test/Bitcode/2021-07-22-Parse-Metadata-Operand-Bundles.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
; This test ensures that we parse metadata operand bundle values.
; RUN: llvm-as < %s
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No CHECK lines? is this just a test that llvm-as doesn't crash?


declare void @callee()

define void @call_with_operand_bundle() {
call void @callee() [ "op_type"(metadata !"metadata_string") ]
ret void
}
Loading