Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RISCV] Support rv{32, 64}e in the compiler builtins #88252

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

xermicus
Copy link
Contributor

Register spills (save/restore) in RISC-V embedded work differently because there are less registers and different stack alignment.

GCC equivalent

Follow up from #76777.

CC @koute @wangpc-pp

…estore) In RISC-V embedded work differently because there are less registers and different stack alignment.

Signed-off-by: xermicus <cyrill@parity.io>
Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

Signed-off-by: xermicus <cyrill@parity.io>
Copy link
Contributor

@wangpc-pp wangpc-pp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
@koute Do you have any comments?

Copy link

@koute koute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xermicus Thanks for the PR! I was meaning to do this myself but it ended up being on the backburner. (:

LGTM

Copy link
Member

@kito-cheng kito-cheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@wangpc-pp wangpc-pp merged commit bd32aaa into llvm:main Apr 11, 2024
4 checks passed
Copy link

@xermicus Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested
by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as
the builds can include changes from many authors. It is not uncommon for your
change to be included in a build that fails due to someone else's changes, or
infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself.
This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

@xermicus xermicus deleted the cl/rve-builtins branch April 11, 2024 10:12
@xermicus xermicus restored the cl/rve-builtins branch April 12, 2024 12:47
@xermicus
Copy link
Contributor Author

@wangpc-pp thanks for merging! Should this be backported to release/18.x?

@wangpc-pp
Copy link
Contributor

@wangpc-pp thanks for merging! Should this be backported to release/18.x?

Yeah, I think so! We have supported RVE in 18.x, but it isn't fully supported without this change.

@wangpc-pp
Copy link
Contributor

/cherry-pick bd32aaa

@llvmbot
Copy link
Collaborator

llvmbot commented Apr 12, 2024

Failed to create pull request for issue88252 https://github.com/llvm/llvm-project/actions/runs/8663009660

@wangpc-pp
Copy link
Contributor

/cherry-pick bd32aaa

llvmbot pushed a commit to llvmbot/llvm-project that referenced this pull request Apr 12, 2024
Register spills (save/restore) in RISC-V embedded work differently
because there are less registers and different stack alignment.

[GCC equivalent
](https://github.com/gcc-mirror/gcc/blob/master/libgcc/config/riscv/save-restore.S#L298C16-L336)

Follow up from llvm#76777.

---------

Signed-off-by: xermicus <cyrill@parity.io>
(cherry picked from commit bd32aaa)
@llvmbot
Copy link
Collaborator

llvmbot commented Apr 12, 2024

/pull-request #88525

@xermicus
Copy link
Contributor Author

Excellent! I agree

tstellar pushed a commit to llvmbot/llvm-project that referenced this pull request Apr 15, 2024
Register spills (save/restore) in RISC-V embedded work differently
because there are less registers and different stack alignment.

[GCC equivalent
](https://github.com/gcc-mirror/gcc/blob/master/libgcc/config/riscv/save-restore.S#L298C16-L336)

Follow up from llvm#76777.

---------

Signed-off-by: xermicus <cyrill@parity.io>
(cherry picked from commit bd32aaa)
@pointhex pointhex mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants