Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lldb] Fix typo in CumulativeSystemTimeIsValid check #89680

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

marcauberer
Copy link
Member

Resolves #89674

@llvmbot
Copy link
Collaborator

llvmbot commented Apr 22, 2024

@llvm/pr-subscribers-lldb

Author: Marc Auberer (marcauberer)

Changes

Resolves #89674


Full diff: https://github.com/llvm/llvm-project/pull/89680.diff

1 Files Affected:

  • (modified) lldb/include/lldb/Utility/ProcessInfo.h (+1-2)
diff --git a/lldb/include/lldb/Utility/ProcessInfo.h b/lldb/include/lldb/Utility/ProcessInfo.h
index e9fe71e1b851d1..85489c0ef0a199 100644
--- a/lldb/include/lldb/Utility/ProcessInfo.h
+++ b/lldb/include/lldb/Utility/ProcessInfo.h
@@ -233,8 +233,7 @@ class ProcessInstanceInfo : public ProcessInfo {
   }
 
   bool CumulativeSystemTimeIsValid() const {
-    return m_cumulative_system_time.tv_sec > 0 ||
-           m_cumulative_system_time.tv_sec > 0;
+    return m_cumulative_system_time.tv_sec > 0;
   }
 
   void Dump(Stream &s, UserIDResolver &resolver) const;

@marcauberer marcauberer force-pushed the lldb/rework-duplicate-predicate branch from d5bd3f3 to b626dc5 Compare April 22, 2024 22:11
@marcauberer marcauberer changed the title [lldb] Remove duplicate disjunction in CumulativeSystemTimeIsValid [lldb] Fix typo in CumulativeSystemTimeIsValid check Apr 22, 2024
@JDevlieghere
Copy link
Member

Can this be tested in HostTest.cpp?

@marcauberer marcauberer force-pushed the lldb/rework-duplicate-predicate branch from b626dc5 to c028b10 Compare April 25, 2024 22:58
@marcauberer marcauberer merged commit 266a927 into llvm:main Apr 26, 2024
4 checks passed
@marcauberer marcauberer deleted the lldb/rework-duplicate-predicate branch April 26, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lldb/include/lldb/Utility/ProcessInfo.h:236: Same expression on both sides of '||'
3 participants