[Flang] Add fallthrough annotations in visit.h #90014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klausler
approved these changes
Apr 25, 2024
|
@alexander-shaposhnikov, FYI, this broke Fortran runtime builders: https://lab.llvm.org/buildbot/#/builders/267/builds/1277 |
alexander-shaposhnikov
added a commit
that referenced
this pull request
Apr 25, 2024
This reverts commit eb05a2e. (The comming broke Fortran runtime builders: https://lab.llvm.org/buildbot/#/builders/267/builds/1277)
|
Thank you! It looks like the issue might be related only to out-of-tree builds of |
|
p.s. i think we probably no longer need to use a macro since LLVM now requires c++17 and [[fallthrough]] may be used directly. |
alexander-shaposhnikov
added a commit
that referenced
this pull request
Apr 25, 2024
Use [[fallthrough]] directly (similarly to https://reviews.llvm.org/D131346). This recommits eb05a2e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add fallthrough annotations to avoid warnings if -Wimplicit-fallthrough is enabled.
Note, LLVM_FALLTHROUGH can't be included into VISIT_CASE_N - it would cause a compile error for the last case.
Test plan: ninja check-all