[llvm-objcopy] Add verification of added .note section format #90458

serge-sans-paille · 2024-04-29T11:35:11Z

No description provided.

llvmbot · 2024-04-29T11:35:39Z

@llvm/pr-subscribers-llvm-binary-utilities

Author: None (serge-sans-paille)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/90458.diff

2 Files Affected:

(modified) llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp (+64-6)
(added) llvm/test/tools/llvm-objcopy/ELF/add-invalid-note.test (+35)

diff --git a/llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp b/llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp
index f343d1447e0554..90e59a5228d6fe 100644
--- a/llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp
+++ b/llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp
@@ -623,6 +623,58 @@ handleUserSection(const NewSectionInfo &NewSection,
   return F(NewSection.SectionName, Data);
 }
 
+static Error verifyNoteSection(StringRef Name, llvm::endianness E,
+                               ArrayRef<uint8_t> Data) {
+
+// An ELF note have the following structure:
+// Name Size: 4 bytes (integer)
+// Desc Size: 4 bytes (integer)
+// Type     : 4 bytes
+// Name     : variable size, padded to a 4 byte boundary
+// Desc     : variable size, padded to a 4 byte boundary
+
+  if (Data.empty())
+    return Error::success();
+
+  if (Data.size() < 12) {
+    std::string msg;
+    raw_string_ostream(msg)
+        << Name << " data must be either empty or at least 12 bytes long.";
+    return createStringError(errc::invalid_argument, msg);
+  }
+  if (Data.size() % 4 != 0) {
+    std::string msg;
+    raw_string_ostream(msg)
+        << Name << " data size must be a  multiple of 4 bytes.";
+    return createStringError(errc::invalid_argument, msg);
+  }
+  ArrayRef<uint8_t> NameSize = Data.slice(0, 4);
+  ArrayRef<uint8_t> DescSize = Data.slice(4, 4);
+
+  uint32_t NameSizeValue, DescSizeValue;
+  std::memcpy(&NameSizeValue, NameSize.data(), 4);
+  std::memcpy(&DescSizeValue, DescSize.data(), 4);
+
+  if (llvm::endianness::native != E) {
+    NameSizeValue = byteswap(NameSizeValue);
+    DescSizeValue = byteswap(DescSizeValue);
+  }
+  uint64_t ExpectedDataSize =
+      4 + 4 + 4 + (NameSizeValue + 3) / 4 * 4 + (DescSizeValue + 3) / 4 * 4;
+  uint64_t ActualDataSize = Data.size();
+  if (ActualDataSize != ExpectedDataSize) {
+    std::string msg;
+    raw_string_ostream(msg) << Name
+                            << " data size is incompatible with the content of "
+                               "the name and description size fields:"
+                            << " expecting " << ExpectedDataSize << ", found "
+                            << ActualDataSize << ".";
+    return createStringError(errc::invalid_argument, msg);
+  }
+
+  return Error::success();
+}
+
 // This function handles the high level operations of GNU objcopy including
 // handling command line options. It's important to outline certain properties
 // we expect to hold of the command line operations. Any operation that "keeps"
@@ -631,7 +683,7 @@ handleUserSection(const NewSectionInfo &NewSection,
 // depend a) on the order the options occur in or b) on some opaque priority
 // system. The only priority is that keeps/copies overrule removes.
 static Error handleArgs(const CommonConfig &Config, const ELFConfig &ELFConfig,
-                        Object &Obj) {
+                        ElfType OutputElfType, Object &Obj) {
   if (Config.OutputArch) {
     Obj.Machine = Config.OutputArch->EMachine;
     Obj.OSABI = Config.OutputArch->OSABI;
@@ -675,12 +727,18 @@ static Error handleArgs(const CommonConfig &Config, const ELFConfig &ELFConfig,
       if (Sec.Flags & SHF_ALLOC && Sec.Type != SHT_NOTE)
         Sec.Type = SHT_NOBITS;
 
+  endianness E = OutputElfType == ELFT_ELF32LE || OutputElfType == ELFT_ELF64LE
+                     ? endianness::little
+                     : endianness::big;
+
   for (const NewSectionInfo &AddedSection : Config.AddSection) {
-    auto AddSection = [&](StringRef Name, ArrayRef<uint8_t> Data) {
+    auto AddSection = [&](StringRef Name, ArrayRef<uint8_t> Data) -> Error {
       OwnedDataSection &NewSection =
           Obj.addSection<OwnedDataSection>(Name, Data);
-      if (Name.starts_with(".note") && Name != ".note.GNU-stack")
+      if (Name.starts_with(".note") && Name != ".note.GNU-stack") {
         NewSection.Type = SHT_NOTE;
+        return verifyNoteSection(Name, E, Data);
+      }
       return Error::success();
     };
     if (Error E = handleUserSection(AddedSection, AddSection))
@@ -813,7 +871,7 @@ Error objcopy::elf::executeObjcopyOnIHex(const CommonConfig &Config,
 
   const ElfType OutputElfType =
       getOutputElfType(Config.OutputArch.value_or(MachineInfo()));
-  if (Error E = handleArgs(Config, ELFConfig, **Obj))
+  if (Error E = handleArgs(Config, ELFConfig, OutputElfType, **Obj))
     return E;
   return writeOutput(Config, **Obj, Out, OutputElfType);
 }
@@ -831,7 +889,7 @@ Error objcopy::elf::executeObjcopyOnRawBinary(const CommonConfig &Config,
   // (-B<arch>).
   const ElfType OutputElfType =
       getOutputElfType(Config.OutputArch.value_or(MachineInfo()));
-  if (Error E = handleArgs(Config, ELFConfig, **Obj))
+  if (Error E = handleArgs(Config, ELFConfig, OutputElfType, **Obj))
     return E;
   return writeOutput(Config, **Obj, Out, OutputElfType);
 }
@@ -850,7 +908,7 @@ Error objcopy::elf::executeObjcopyOnBinary(const CommonConfig &Config,
                                     ? getOutputElfType(*Config.OutputArch)
                                     : getOutputElfType(In);
 
-  if (Error E = handleArgs(Config, ELFConfig, **Obj))
+  if (Error E = handleArgs(Config, ELFConfig, OutputElfType, **Obj))
     return createFileError(Config.InputFilename, std::move(E));
 
   if (Error E = writeOutput(Config, **Obj, Out, OutputElfType))
diff --git a/llvm/test/tools/llvm-objcopy/ELF/add-invalid-note.test b/llvm/test/tools/llvm-objcopy/ELF/add-invalid-note.test
new file mode 100644
index 00000000000000..396b6ebaaaf4e5
--- /dev/null
+++ b/llvm/test/tools/llvm-objcopy/ELF/add-invalid-note.test
@@ -0,0 +1,35 @@
+# Verify that --add-section can be used to add a note section which is
+# successfully interpreted by tools that read notes.
+
+# Add [namesz, descsz, type, name, desc] for a build id.
+#
+# RUN: echo -e -n "\x04\x00\x00\x00" >  %t-miss-padding-note.bin
+# RUN: echo -e -n "\x07\x00\x00\x00" >> %t-miss-padding-note.bin
+# RUN: echo -e -n "\x03\x00\x00\x00" >> %t-miss-padding-note.bin
+# RUN: echo -e -n "GNU\x00"          >> %t-miss-padding-note.bin
+# RUN: echo -e -n "\x0c\x0d\x0e"     >> %t-miss-padding-note.bin
+#
+# RUN: echo -e -n "\x08\x00\x00\x00" >  %t-invalid-size-note.bin
+# RUN: echo -e -n "\x07\x00\x00\x00" >> %t-invalid-size-note.bin
+# RUN: echo -e -n "\x03\x00\x00\x00" >> %t-invalid-size-note.bin
+# RUN: echo -e -n "GNU\x00"          >> %t-invalid-size-note.bin
+# RUN: echo -e -n "\x0c\x0d\x0e\x00" >> %t-invalid-size-note.bin
+
+# RUN: echo -e -n "\x08\x00\x00\x00" >  %t-short-note.bin
+# RUN: echo -e -n "\x07\x00\x00\x00" >> %t-short-note.bin
+
+# RUN: yaml2obj %s -o %t.o
+# RUN: not llvm-objcopy --add-section=.note.miss.padding=%t-miss-padding-note.bin %t.o %t-with-note.o 2>&1 | FileCheck --check-prefix=CHECK-MISS-PADDING %s
+# RUN: not llvm-objcopy --add-section=.note.invalid.size=%t-invalid-size-note.bin %t.o %t-with-note.o 2>&1 | FileCheck --check-prefix=CHECK-INVALID-SIZE %s
+# RUN: not llvm-objcopy --add-section=.note.short=%t-short-note.bin %t.o %t-with-note.o 2>&1 | FileCheck --check-prefix=CHECK-SHORT %s
+
+!ELF
+FileHeader:
+  Class:           ELFCLASS64
+  Data:            ELFDATA2LSB
+  Type:            ET_REL
+  Machine:         EM_X86_64
+
+# CHECK-MISS-PADDING: .note.miss.padding data size must be a multiple of 4 bytes.
+# CHECK-INVALID-SIZE: .note.invalid.size data size is incompatible with the content of the name and description size fields: expecting 28, found 20.
+# CHECK-SHORT: .note.short data must be either empty or at least 12 bytes long.

github-actions · 2024-04-29T11:38:03Z

✅ With the latest revision this PR passed the C/C++ code formatter.

serge-sans-paille · 2024-04-29T14:21:29Z

the buildkite failure seems unrelated

MaskRay · 2024-04-29T21:29:44Z

llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp

+  uint64_t ActualDataSize = Data.size();
+  if (ActualDataSize != ExpectedDataSize) {
+    std::string msg;
+    raw_string_ostream(msg) << Name


@bulbazord's #80493 (reverted due to compile time increase) could simplify this.

MaskRay · 2024-04-29T21:33:44Z

I am on the fence whether there should be an error (which will set the exit code to 1 and suppress the output).

One use case for --add-section is to create intentionally invalid object files to test consumers.
While we can check SHT_NOTE, it's not practical to check other section types.
In addition, GNU objcopy doesn't verify the added .note.

jh7370

I agree with @MaskRay that validating added note sections specifically and unconditionally is suboptimal. However, I also can see the benefit of being able to validate .note sections (and possibly other sections, although not as part of this patch). Did you have a specific use-case in mind @serge-sans-paille (e.g. adding an invalid section caused some misery somewhere)?

I have a few competing ideas that would achieve the goal, whilst still maintaining the ability to add invalid sections:

Add a new --validate-notes option that validates all .note sections in the final output (so after adding and stripping etc). Possibly "all" is unnecessary and this could be restricted to just the added ones. Pros: opt-in behaviour means users can continue to add invalid notes deliberately. Cons: existing and new users accidentally adding invalid notes will continue to do so.
Same as above, but make the option the default and provide a "don't validate" option instead. Bascially the same benefits as 1, without the con of people forgetting to add the option, but inconveniences existing users who are deliberately adding an invalid section for whatever reason.
Add a new --add-note-section that is the same as --add-section but specifically for notes, and would do the validation unconditionally. The existing --add-section would continue to be usable for note sections, for backwards and GNU compatibility, but wouldn't do the validation.

Various variations on the above would cover non-note sections too, e.g. --verify-sections,
or even only a specific named section (e.g. --verify-section=... or --verify-note-section=...).

llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp

llvm/test/tools/llvm-objcopy/ELF/add-invalid-note.test

serge-sans-paille · 2024-05-02T07:18:01Z

Thanks for the early comments. My use case was very pragamatic: trying to add a note, forgetting about the required padding and then wondering how to improve the situation. I like the idea of the very explicit --add-note-section that would quite naturally imply a check. @nickclifton do you think we could see that in binutils' objcopy too? That way we would avoid having (too much) diverging CLI.

serge-sans-paille · 2024-05-21T13:32:00Z

@jh7370 : I ended up going to the --verify-note-sections path, as it seems to me that the most common usage is to add a valid note. I debated whether -w (as for disable warning) would be the right approach, not erroring, warning by default with a way to silent warning

jh7370

Please update the PR title/description for the revised behaviour.

Please also update the llvm-objcopy docs and add a release note for the new option.

Finally, please don't force push to active PRs: it makes it difficult to view the difference since the last review (this is why it's against the current LLVM policy). Instead, prefer a merge from main if rebasing is needed.

jh7370 · 2024-05-22T07:24:42Z

llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp

@@ -623,6 +623,58 @@ handleUserSection(const NewSectionInfo &NewSection,
  return F(NewSection.SectionName, Data);
 }

+static Error verifyNoteSection(StringRef Name, endianness Endianness,
+                               ArrayRef<uint8_t> Data) {
+  // An ELF note has the following structure:


Random thought: I wonder if there's a way to leverage existing code in the Object library or llvm-readobj to verify the note, rather than duplicating things? (There might not be a sensible way of doing this, I haven't looked).

It seems possible to hook in llvm::objcopy::elf::Object::addSection, but then it would also be a good opportunity to move the conversion to SHT_NOTE based on the section name there too... Let's investigate that in a follow-up PR

Note: one note section may contain multiple notes.
The practical example is .note.gnu.property.

There is some alignment complexity. See https://reviews.llvm.org/D150022

I always get confused about .note and alignment behaviours. Are you suggesting @MaskRay that some action needs taking here?

Some note sections (.note.gnu.property) have 8-byte alignment. Perhaps add a test that they are supported. @serge-sans-paille

llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp

llvm/test/tools/llvm-objcopy/ELF/add-invalid-note.test

llvm/tools/llvm-objcopy/ObjcopyOpts.td

llvm/docs/CommandGuide/llvm-objcopy.rst

llvm/test/tools/llvm-objcopy/ELF/add-invalid-note.test

llvm/tools/llvm-objcopy/ObjcopyOptions.cpp

llvm/tools/llvm-objcopy/ObjcopyOpts.td

jh7370

This will need adding to the release notes.

@MaskRay: what's your opinion on whether this should be enabled by default? Enabling by default means that those who are accidentally creating invalid notes will be warned about it. On the other hand we'll break people's build, if they are deliberately creating invalid ones (I don't know why you would outside of testing). My inclination is on by default, since there's an easy way to get out of the situation with the new --no-verify-note-sections option.

llvm/docs/CommandGuide/llvm-objcopy.rst

llvm/test/tools/llvm-objcopy/ELF/add-invalid-note.test

MaskRay · 2024-06-06T04:18:44Z

This will need adding to the release notes.

@MaskRay: what's your opinion on whether this should be enabled by default? Enabling by default means that those who are accidentally creating invalid notes will be warned about it. On the other hand we'll break people's build, if they are deliberately creating invalid ones (I don't know why you would outside of testing). My inclination is on by default, since there's an easy way to get out of the situation with the new --no-verify-note-sections option.

objcopy's section/symbol removal/modification features can easily break linking or cause runtime failures, but it is pretty difficult for --add-* to cause failures.

The most probably --add-section .notexxx=xxx users are distributors.
Adding another option for verification could be perceived as annoyance.
The other users use --add-section .notexxx=xxx to deliberately create invalid files to another tool, which is probably niche.
These folks are likely more amenable to additional complexity.

I agree with you that verification can be on by default.

MaskRay · 2024-06-06T04:19:36Z

[llvm-objdump] Add possibility to verify .note section format

The subject line is still wrong. It should be llvm-objcopy

llvm/test/tools/llvm-objcopy/ELF/add-invalid-note.test

serge-sans-paille · 2024-06-13T13:33:31Z

(add to push --force to resolve conflict + change original commit title)

serge-sans-paille · 2024-06-16T14:50:57Z

@MaskRay : all green and comments taken into account.

Also add a --no-verify-note-sections flag to make it possible to add invalid sections if needs be.

… notes

serge-sans-paille · 2024-06-17T21:12:02Z

(rebased to fix merge conflict)

jh7370 · 2024-06-18T07:33:48Z

(rebased to fix merge conflict)

Please review the LLVM pull request guidelines: do not do a force push unless absolutely essential. You can use merge commits to merge in changes from main into your feature branch instead. Using a force push results in the old commits being wiped and it is no longer trivial to diff the change against the previous version that was reviewed.

llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp

llvm/test/tools/llvm-objcopy/ELF/add-invalid-note.test

jh7370 · 2024-06-18T09:09:46Z

llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp

@@ -623,6 +623,58 @@ handleUserSection(const NewSectionInfo &NewSection,
  return F(NewSection.SectionName, Data);
 }

+static Error verifyNoteSection(StringRef Name, endianness Endianness,
+                               ArrayRef<uint8_t> Data) {
+  // An ELF note has the following structure:


I always get confused about .note and alignment behaviours. Are you suggesting @MaskRay that some action needs taking here?

jh7370

Please don't "resolve conversations" where I've instigated a change request comment. See https://discourse.llvm.org/t/rfc-github-pr-resolve-conversation-button for more context.

… notes

llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp

… notes

MaskRay · 2024-07-10T18:03:29Z

llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp

+  uint32_t NameSizeValue = *reinterpret_cast<const uint32_t *>(NameSize.data());
+  uint32_t DescSizeValue = *reinterpret_cast<const uint32_t *>(DescSize.data());
+
+  if (Endianness != endianness::native) {


endian::read32 should make byteswap unnecessary.

… notes

MaskRay

LGTM, but please give jh7370 time to verify

llvm/test/tools/llvm-objcopy/ELF/add-invalid-note.test

llvm/docs/CommandGuide/llvm-objcopy.rst

llvm/test/tools/llvm-objcopy/ELF/add-invalid-note.test

… notes

jh7370

LGTM, but could you make some changes to the PR title and description as follows, please, before merging?

Change the title to "[llvm-objcopy] Add verification of added .note section format". This makes it clearer that the new behaviour is on by default.
Add a description outlining the new behaviour, in particular the new options, in more detail. Something like:

This commit adds a --verify-note-sections option to llvm-objcopy, which enables checking that added .note sections conform to the SHT_NOTE section format. This option is enabled by default, but can be disabled with --no-verify-note-sections.

jh7370 · 2024-07-11T10:26:30Z

P.S. It would be worth waiting before landing this to allow for the pre-merge checks to finish, so that you can make sure any failures are unrelated to your change.

Also add a --no-verify-note-sections flag to make it possible to add invalid sections if needs be. Pull Request: #90458

serge-sans-paille · 2024-07-11T16:01:40Z

Commited as fb5a38b

serge-sans-paille · 2024-07-11T16:02:36Z

Thanks @MaskRay and @jh7370 for the throughful review.

Also add a --no-verify-note-sections flag to make it possible to add invalid sections if needs be. Pull Request: llvm#90458

llvmbot added the llvm:binary-utilities label Apr 29, 2024

serge-sans-paille requested a review from MaskRay April 29, 2024 11:35

serge-sans-paille force-pushed the feature/objcopy-note branch from 2aaf91d to 8df8478 Compare April 29, 2024 12:18

MaskRay reviewed Apr 29, 2024

View reviewed changes

MaskRay requested a review from jh7370 April 29, 2024 21:33

jh7370 reviewed Apr 30, 2024

View reviewed changes

serge-sans-paille force-pushed the feature/objcopy-note branch from 8df8478 to 2f2a5be Compare May 21, 2024 07:55

jh7370 reviewed May 22, 2024

View reviewed changes

serge-sans-paille changed the title ~~[llvm-objdump] Error with relevant message when adding invalid notes~~ [llvm-objdump] Add possibility to verify .note section format Jun 3, 2024

jh7370 reviewed Jun 4, 2024

View reviewed changes

jh7370 reviewed Jun 5, 2024

View reviewed changes

MaskRay reviewed Jun 6, 2024

View reviewed changes

llvm/test/tools/llvm-objcopy/ELF/add-invalid-note.test Outdated Show resolved Hide resolved

serge-sans-paille force-pushed the feature/objcopy-note branch 2 times, most recently from 398cd75 to c4afad6 Compare June 13, 2024 13:33

serge-sans-paille changed the title ~~[llvm-objdump] Add possibility to verify .note section format~~ [llvm-objcopy] Add possibility to verify .note section format Jun 13, 2024

serge-sans-paille added 5 commits June 17, 2024 23:09

[llvm-objcopy] Error with relevant message when adding invalid notes

7483002

Also add a --no-verify-note-sections flag to make it possible to add invalid sections if needs be.

fixup! [llvm-objcopy] Error with relevant message when adding invalid…

f3c0f53

… notes

fixup! [llvm-objcopy] Error with relevant message when adding invalid…

1a4aa18

… notes

fixup! [llvm-objcopy] Error with relevant message when adding invalid…

2c82ed7

… notes

fixup! [llvm-objcopy] Error with relevant message when adding invalid…

36daa11

… notes

serge-sans-paille force-pushed the feature/objcopy-note branch from c4afad6 to 36daa11 Compare June 17, 2024 21:11

jh7370 reviewed Jun 18, 2024

View reviewed changes

fixup! [llvm-objcopy] Error with relevant message when adding invalid…

a9e09b8

… notes

jh7370 reviewed Jun 19, 2024

View reviewed changes

llvm/lib/ObjCopy/ELF/ELFObjcopy.cpp Outdated Show resolved Hide resolved

serge-sans-paille added 2 commits July 10, 2024 16:27

Merge branch 'main' into feature/objcopy-note

6861413

fixup! [llvm-objcopy] Error with relevant message when adding invalid…

bb4ca67

… notes

MaskRay reviewed Jul 10, 2024

View reviewed changes

fixup! [llvm-objcopy] Error with relevant message when adding invalid…

8c4abe2

… notes

serge-sans-paille force-pushed the feature/objcopy-note branch from 45e026e to 8c4abe2 Compare July 10, 2024 21:27

MaskRay approved these changes Jul 11, 2024

View reviewed changes

jh7370 reviewed Jul 11, 2024

View reviewed changes

fixup! [llvm-objcopy] Error with relevant message when adding invalid…

1f4dc6b

… notes

jh7370 approved these changes Jul 11, 2024

View reviewed changes

serge-sans-paille changed the title ~~[llvm-objcopy] Add possibility to verify .note section format~~ [llvm-objcopy] Add verification of added .note section format Jul 11, 2024

serge-sans-paille added a commit that referenced this pull request Jul 11, 2024

[llvm-objcopy] Add verification of added .note section format

fb5a38b

Also add a --no-verify-note-sections flag to make it possible to add invalid sections if needs be. Pull Request: #90458

serge-sans-paille closed this Jul 11, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[llvm-objcopy] Add verification of added .note section format #90458

[llvm-objcopy] Add verification of added .note section format #90458

serge-sans-paille commented Apr 29, 2024

llvmbot commented Apr 29, 2024

github-actions bot commented Apr 29, 2024 •

edited

Loading

serge-sans-paille commented Apr 29, 2024

MaskRay Apr 29, 2024

MaskRay commented Apr 29, 2024 •

edited

Loading

jh7370 left a comment

serge-sans-paille commented May 2, 2024

serge-sans-paille commented May 21, 2024

jh7370 left a comment

jh7370 May 22, 2024

serge-sans-paille Jun 3, 2024

MaskRay Jun 6, 2024

jh7370 Jun 18, 2024

MaskRay Jul 10, 2024

jh7370 left a comment

MaskRay commented Jun 6, 2024

MaskRay commented Jun 6, 2024

serge-sans-paille commented Jun 13, 2024

serge-sans-paille commented Jun 16, 2024

serge-sans-paille commented Jun 17, 2024

jh7370 commented Jun 18, 2024

jh7370 Jun 18, 2024

jh7370 left a comment

MaskRay Jul 10, 2024

serge-sans-paille Jul 10, 2024

MaskRay left a comment

jh7370 left a comment •

edited

Loading

jh7370 commented Jul 11, 2024

serge-sans-paille commented Jul 11, 2024

serge-sans-paille commented Jul 11, 2024

[llvm-objcopy] Add verification of added .note section format #90458

[llvm-objcopy] Add verification of added .note section format #90458

Conversation

serge-sans-paille commented Apr 29, 2024

llvmbot commented Apr 29, 2024

github-actions bot commented Apr 29, 2024 • edited Loading

serge-sans-paille commented Apr 29, 2024

Choose a reason for hiding this comment

MaskRay commented Apr 29, 2024 • edited Loading

jh7370 left a comment

Choose a reason for hiding this comment

serge-sans-paille commented May 2, 2024

serge-sans-paille commented May 21, 2024

jh7370 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jh7370 left a comment

Choose a reason for hiding this comment

MaskRay commented Jun 6, 2024

MaskRay commented Jun 6, 2024

serge-sans-paille commented Jun 13, 2024

serge-sans-paille commented Jun 16, 2024

serge-sans-paille commented Jun 17, 2024

jh7370 commented Jun 18, 2024

Choose a reason for hiding this comment

jh7370 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MaskRay left a comment

Choose a reason for hiding this comment

jh7370 left a comment • edited Loading

Choose a reason for hiding this comment

jh7370 commented Jul 11, 2024

serge-sans-paille commented Jul 11, 2024

serge-sans-paille commented Jul 11, 2024

github-actions bot commented Apr 29, 2024 •

edited

Loading

MaskRay commented Apr 29, 2024 •

edited

Loading

jh7370 left a comment •

edited

Loading