Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[libc] fix typo due to futex renaming #91379

Merged
merged 1 commit into from
May 7, 2024

Conversation

SchrodingerZhu
Copy link
Contributor

It is strange that cmake did not error on this.

@SchrodingerZhu SchrodingerZhu requested a review from lntue May 7, 2024 19:05
@SchrodingerZhu SchrodingerZhu self-assigned this May 7, 2024
@llvmbot llvmbot added the libc label May 7, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented May 7, 2024

@llvm/pr-subscribers-libc

Author: Schrodinger ZHU Yifan (SchrodingerZhu)

Changes

It is strange that cmake did not error on this.


Full diff: https://github.com/llvm/llvm-project/pull/91379.diff

1 Files Affected:

  • (modified) libc/src/__support/threads/linux/CMakeLists.txt (+1-1)
diff --git a/libc/src/__support/threads/linux/CMakeLists.txt b/libc/src/__support/threads/linux/CMakeLists.txt
index b277c2a37f2d0f..9bee30206f1b9f 100644
--- a/libc/src/__support/threads/linux/CMakeLists.txt
+++ b/libc/src/__support/threads/linux/CMakeLists.txt
@@ -27,7 +27,7 @@ add_header_library(
   HDRS
     mutex.h
   DEPENDS
-    .futex
+    .futex_utils
     libc.src.__support.threads.mutex_common
 )
 

Copy link
Contributor

@michaelrj-google michaelrj-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way our cmake is set up, if a target is missing a dependency it will just skip that target (and anything that depends on it). You can get warnings for this with -DLIBC_CMAKE_VERBOSE_LOGGING=ON.

@SchrodingerZhu SchrodingerZhu merged commit a5044e6 into llvm:main May 7, 2024
6 checks passed
@SchrodingerZhu SchrodingerZhu deleted the libc/futex-fix branch May 7, 2024 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants