[nfc] Clarify when the various PGO instrumentation passes run #92330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code seems easier to read if it's centered on what the user wants rather than combinations of whatever internal variables.
| if (PGOOpt && Phase != ThinOrFullLTOPhase::ThinLTOPostLink && | ||
| (PGOOpt->Action == PGOOptions::IRInstr || | ||
| PGOOpt->Action == PGOOptions::IRUse || !PGOOpt->MemoryProfile.empty())) | ||
| const bool IsPreLink = Phase != ThinOrFullLTOPhase::ThinLTOPostLink; |
There was a problem hiding this comment.
Can you add a comment above here that we have already asserted that this is not being executed for the FullLTOPostLink phase? So this is specific to ThinLTO and non-LTO.
| IsPGOPreLink && PGOOpt->Action == PGOOptions::IRInstr; | ||
| const bool IsPGOInstrUse = | ||
| IsPGOPreLink && PGOOpt->Action == PGOOptions::IRUse; | ||
| const bool IsMemprof = IsPGOPreLink && !PGOOpt->MemoryProfile.empty(); |
There was a problem hiding this comment.
Suggest IsMemprofUse.
| const bool IsMemprof = IsPGOPreLink && !PGOOpt->MemoryProfile.empty(); | ||
| // We don't want to mix pgo ctx gen and pgo gen; we also don't currently | ||
| // enable ctx profiling from the frontend. | ||
| const bool IsCtxProfGen = !IsPGOInstrGen && IsPreLink && |
There was a problem hiding this comment.
Can you split out the Ctx profiling stuff into a different PR as that makes this one non-NFC and is separate from the PR description?
teresajohnson
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code seems easier to read if it's centered on what the user wants rather than combinations of whatever internal variables.