[ctx_profile] Decouple ctx instrumentation from PGOOpt #92445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently don't support passing files and don't need frontend involvment either.
teresajohnson
approved these changes
May 16, 2024
| @@ -1157,8 +1153,12 @@ PassBuilder::buildModuleSimplificationPipeline(OptimizationLevel Level, | |||
| const bool IsPGOInstrUse = | |||
| IsPGOPreLink && PGOOpt->Action == PGOOptions::IRUse; | |||
| const bool IsMemprofUse = IsPGOPreLink && !PGOOpt->MemoryProfile.empty(); | |||
| // We don't want to mix pgo ctx gen and pgo gen; we also don't currently | |||
There was a problem hiding this comment.
should there be an assert that fires if both are enabled?
| @@ -1168,9 +1168,13 @@ PassBuilder::buildModuleSimplificationPipeline(OptimizationLevel Level, | |||
| /*IsCS=*/false, PGOOpt->AtomicCounterUpdate, | |||
| PGOOpt->ProfileFile, PGOOpt->ProfileRemappingFile, | |||
| PGOOpt->FS); | |||
| } else if (IsCtxProfGen) { | |||
| MPM.addPass(PGOInstrumentationGen(false)); | |||
There was a problem hiding this comment.
document constant parameter
qiaojbao
pushed a commit
to GPUOpen-Drivers/llvm-project
that referenced
this pull request
Jun 5, 2024
…1da5ad733 Local branch amd-gfx 3c31da5 Merged main:911207338add39b8439a09fd7f9d97bbe4a335bd into amd-gfx:3ae085055ecb Remote branch main d311a62 [ctx_profile] Decouple ctx instrumentation from PGOOpt (llvm#92445)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently don't support passing files and don't need frontend involvment either.