Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[llvm-cov] Coverage report HTML UI to jump between uncovered parts of code #95662

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

hanickadot
Copy link
Contributor

I replaced "jump to first uncovered line" with UI buttons and keyboard shortcut to jump between uncovered parts of code: lines (key L), branchs (key B), regions (key R).

User can also jump in reverse direction with shift+key.

@hanickadot
Copy link
Contributor Author

Motivation: I recently was writing tests for uncovered code in a long file and I spend a lot of time scrolling and looking for missing uncovered lines inside instantiation (to which the link "jump to first uncovered line" didn't even work.

@hanickadot
Copy link
Contributor Author

hanickadot commented Jun 15, 2024

Screenshot before:
Screenshot 2024-06-15 at 17 37 17
video link

Screenshot after:
Screenshot 2024-06-15 at 17 35 06
video link

@hanickadot hanickadot force-pushed the feature/llvm-cov-jumping branch 3 times, most recently from e091967 to 2b88afe Compare June 15, 2024 16:45
@hanickadot
Copy link
Contributor Author

@hanickadot hanickadot force-pushed the feature/llvm-cov-jumping branch 4 times, most recently from e1099d9 to 67b1ec3 Compare June 16, 2024 19:52
@ornata
Copy link

ornata commented Jun 17, 2024

Cool! I tested in Firefox, Safari, and Chrome and the feature works in all 3.

@chapuni
Copy link
Contributor

chapuni commented Jun 17, 2024

Could we split out .css and .js to individual include files in the future? (I don't think we should do right now)

@hanickadot
Copy link
Contributor Author

Could we split out .css and .js to individual include files in the future? (I don't think we should do right now)

Oh, I wish we could just #embed it :)

@chapuni
Copy link
Contributor

chapuni commented Jun 17, 2024

@hanickadot Meant, on the source tree.

Copy link

github-actions bot commented Jun 17, 2024

✅ With the latest revision this PR passed the C/C++ code formatter.

@hanickadot hanickadot force-pushed the feature/llvm-cov-jumping branch 2 times, most recently from e63ac16 to e2b3815 Compare June 17, 2024 07:02
Copy link
Contributor

@chapuni chapuni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok-maru-suisan, thanks! @hanickadot

@hanickadot hanickadot merged commit 06aa078 into llvm:main Jun 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants