Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-aarch64-full-2stage: build lld for stage2 tests #139

Merged
merged 1 commit into from Mar 22, 2024

Conversation

OCHyams
Copy link
Contributor

@OCHyams OCHyams commented Mar 19, 2024

A new bitcode format for debug info was added in LLVM in
e419084da7a00b269368aeb95698e0d36b24e8ec (currently reverted).

Several tests started failing for this stage2 builder: https://lab.llvm.org/buildbot/#/builders/179/builds/9629

The error indicates the tests are using an incompatible lld to load the new bitcode:
ld.lld: error: Invalid value (Producer: 'LLVM19.0.0git' Reader: 'LLVM 17.0.6')

Locally, re-enabling the currently reverted patch, these tests pass if LLD is built with LLVM_ENABLE_PROJECTS, and fail otherwise.


I don't really know how zorg works - I'm not sure if this is the right way to get the stage2 build to build an lld for those tests to use. I think a stage1 build of lld would also be fine, if those tests can find it? Any help would be appreciated.

A new bitcode format for debug info was added in
e419084da7a00b269368aeb95698e0d36b24e8ec (currently reverted).

Several tests started failing for this stage2 builder:
https://lab.llvm.org/buildbot/#/builders/179/builds/9629

The error indicates the tests are using an incompatible lld to load the new
bitcode:
ld.lld: error: Invalid value (Producer: 'LLVM19.0.0git' Reader: 'LLVM 17.0.6')

Locally, re-enabling the currently reverted patch, these tests pass if LLD is
built with LLVM_ENABLE_PROJECTS, and fail otherwise.
@OCHyams
Copy link
Contributor Author

OCHyams commented Mar 21, 2024

cc @DavidSpickett (git blame nearby) @tstellar (bot owner, I think), if you're able to look at this or point me to an appropriate reviewer that'd be very much appreciated

@antmox antmox requested a review from omjavaid March 21, 2024 12:11
@antmox
Copy link
Contributor

antmox commented Mar 21, 2024

added @omjavaid who might know zorg enough to review this

Copy link
Contributor

@omjavaid omjavaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me.

@OCHyams OCHyams merged commit 61ae28a into llvm:main Mar 22, 2024
@OCHyams
Copy link
Contributor Author

OCHyams commented Mar 22, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants