[Tcp] Updated bazel rules to build Tcp related targets #1726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjain-stanford
approved these changes
Dec 15, 2022
There was a problem hiding this comment.
LGTM, thank you for sending this! Before landing, could you also do the following?
- Run buildifier and push changes if any:
bazel run @torch-mlir//:buildifier - Trigger a GHA run on your fork and link it in the PR. Actions -> Bazel Build and Test -> Run workflow -> Select your branch and hit Run.
navahgar
force-pushed
the
raghavanr/bazel-rules
branch
from
072c2b0
to
80bc856
Compare
|
Thanks for the review @sjain-stanford
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the bazel rules needed to build Tcp dialect and TorchtoTcp as well as TcpToLinalg conversions.