Support aten.stack op and decompose it into unsqueeze & cat #1747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
li-plus
force-pushed
the
stack-op
branch
3 times, most recently
from
405820e
to
e12200a
Compare
ramiro050
requested changes
Dec 22, 2022
python/torch_mlir/dialects/torch/importer/jit_ir/build_tools/abstract_interp_lib_gen.py
Outdated
Show resolved
Hide resolved
This was referenced Jan 11, 2023
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Mar 7, 2023
As @ramiro050 requested in llvm/torch-mlir#1747, this PR moved the shape code for stack op from torch-mlir to pytorch upstream. Pull Request resolved: #92205 Approved by: https://github.com/eellison
ramiro050
requested changes
Mar 7, 2023
li-plus
force-pushed
the
stack-op
branch
4 times, most recently
from
cfc1b6f
to
3f98c61
Compare
ramiro050
approved these changes
Mar 10, 2023
ydwu4
pushed a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 10, 2023
As @ramiro050 requested in llvm/torch-mlir#1747, this PR moved the shape code for stack op from torch-mlir to pytorch upstream. Pull Request resolved: pytorch#92205 Approved by: https://github.com/eellison
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
As @ramiro050 requested in llvm/torch-mlir#1747, this PR moved the shape code for stack op from torch-mlir to pytorch upstream. Pull Request resolved: pytorch/pytorch#92205 Approved by: https://github.com/eellison
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 12, 2023
As @ramiro050 requested in llvm/torch-mlir#1747, this PR moved the shape code for stack op from torch-mlir to pytorch upstream. Pull Request resolved: pytorch/pytorch#92205 Approved by: https://github.com/eellison
ydwu4
added a commit
to ydwu4/pytorch
that referenced
this pull request
Mar 13, 2023
As @ramiro050 requested in llvm/torch-mlir#1747, this PR moved the shape code for stack op from torch-mlir to pytorch upstream. Pull Request resolved: pytorch#92205 Approved by: https://github.com/eellison
gpetters94
pushed a commit
to gpetters94/mlir-npcomp
that referenced
this pull request
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added
aten.stackop, which will be decomposed into multipleaten.unsqueezeops to create a new dimension for input tensors, and then aaten.catop to concatenate the tensor list along the given dimension.