Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shape function for stack op #92205

Closed
wants to merge 1 commit into from
Closed

Add shape function for stack op #92205

wants to merge 1 commit into from

Conversation

li-plus
Copy link
Contributor

@li-plus li-plus commented Jan 14, 2023

As @ramiro050 requested in llvm/torch-mlir#1747, this PR moved the shape code for stack op from torch-mlir to pytorch upstream.

@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Jan 14, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 14, 2023 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: li-plus / name: Jiahao Li (b33c68b)

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 14, 2023 •
edited

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92205

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 29d44f7:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@ngimel ngimel requested a review from eellison January 14, 2023 21:25
@li-plus
Copy link
Contributor Author

li-plus commented Jan 15, 2023

It seems that assert_jit_shape_analysis=True is not supported if the op input is a list of tensors. Should I remove it?

@li-plus
Copy link
Contributor Author

li-plus commented Jan 18, 2023

Removed assert_jit_shape_analysis=True and now it should pass the CI. Would you approve the workflow?

@bdhirsh bdhirsh added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 18, 2023
@li-plus
Copy link
Contributor Author

li-plus commented Feb 13, 2023

@bdhirsh @eellison hi, is there any update for this?

@eellison
Copy link
Contributor

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased stack-shape onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout stack-shape && git pull --rebase)

@li-plus
Copy link
Contributor Author

li-plus commented Feb 14, 2023

@ngimel hi, would you approve the workflow? Thanks. I'm a first-time contributor.

@li-plus
Copy link
Contributor Author

li-plus commented Feb 17, 2023

@eellison @mruberry @ngimel @bdhirsh hi, would you please approve the workflow and merge this? Thanks. My another PR in torch-mlir relies on this. If anything goes wrong, I'll fix it.

@eellison
Copy link
Contributor

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 17, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job Failing merge rule: Core Maintainers

@li-plus
Copy link
Contributor Author

li-plus commented Feb 22, 2023

@eellison it seems that the CI is failing at unrelated location. Would you force merge this anyway?

@ramiro050
Copy link
Contributor

@eellison, would it be possible to get some help with the CI failure? It seems unrelated to the changes of this patch.

eellison
eellison approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@eellison eellison left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved the ci run, now rebasing.

@eellison
Copy link
Contributor

eellison commented Mar 6, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased stack-shape onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout stack-shape && git pull --rebase)

@eellison
Copy link
Contributor

eellison commented Mar 7, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

ydwu4 pushed a commit to ydwu4/pytorch that referenced this pull request Mar 10, 2023
@li-plus @ydwu4
Add shape function for stack op (pytorch#92205)
e346cd3 
As @ramiro050 requested in llvm/torch-mlir#1747, this PR moved the shape code for stack op from torch-mlir to pytorch upstream.

Pull Request resolved: pytorch#92205
Approved by: https://github.com/eellison
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
@li-plus @cyyever
Add shape function for stack op (#92205)
9d2de7c 
As @ramiro050 requested in llvm/torch-mlir#1747, this PR moved the shape code for stack op from torch-mlir to pytorch upstream.

Pull Request resolved: pytorch/pytorch#92205
Approved by: https://github.com/eellison
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 12, 2023
@li-plus @cyyever
Add shape function for stack op (#92205)
210fe6c 
As @ramiro050 requested in llvm/torch-mlir#1747, this PR moved the shape code for stack op from torch-mlir to pytorch upstream.

Pull Request resolved: pytorch/pytorch#92205
Approved by: https://github.com/eellison
ydwu4 added a commit to ydwu4/pytorch that referenced this pull request Mar 13, 2023
@ydwu4
Add shape function for stack op (pytorch#92205)
76acf5d 
As @ramiro050 requested in llvm/torch-mlir#1747, this PR moved the shape code for stack op from torch-mlir to pytorch upstream.

Pull Request resolved: pytorch#92205
Approved by: https://github.com/eellison
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eellison eellison eellison approved these changes

@mruberry mruberry Awaiting requested review from mruberry

@ngimel ngimel Awaiting requested review from ngimel

Assignees
No one assigned
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged open source release notes: jit release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@li-plus @eellison @pytorchmergebot @ramiro050 @bdhirsh @pytorchbot