Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[torch][quant] Quantized torch.mm for linalg with end-to-end test #2750

Merged
merged 3 commits into from
Jan 24, 2024

Conversation

rsuderman
Copy link
Contributor

This includes custom op matching for decomposed operations and fusing
dequantization into dense operations. As a validation we compare
to the dequant+mm torch implementation.

@dan-garvey
Copy link
Collaborator

Wow what a patch.

@rsuderman
Copy link
Contributor Author

Wow what a patch.

Meanwhile I have flashbacks of Ben's 20k+ line PRs.

Copy link
Collaborator

@stellaraccident stellaraccident left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice: Left a few nits but otherwise looks good.

This includes custom op matching for decomposed operations and fusing
dequantization into dense operations. As a validation we compare
to the dequant+mm torch implementation.
@rsuderman rsuderman merged commit f6f8905 into llvm:main Jan 24, 2024
5 checks passed
@rsuderman rsuderman deleted the quant_mm_rebase branch February 28, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants