Adopt manylinux fix from https://reviews.llvm.org/D111383

[silvasean]

No description provided.

[mikeurbach]

Not sure what the CMake version requirements are here, but I had that conditional since MLIR's minimum is currently 3.13. Looks good to me either way.

[silvasean]

Note to self: retry this after we update to an LLVM version that has pulled in Mike's change. Seems to not work at the moment and we suspect it is cmake getting confused by MLIR asking for Development vs Torch-MLIR asking for Development.Module.

[mikeurbach]

FYI I think this build error may be related to both MLIR and the downstream project (Torch-MLIR in this case) re-using the same CMake variable. I added unset(_python_development_component) in MLIR on my new revision: https://reviews.llvm.org/D111585. Doing that and copying the same for CIRCT appears to work on my Ubuntu machine that failed previously. I'll let you know when the MLIR change is accepted and we can try again here.

EDIT: I think there might still be an issue here, unrelated to unset or not. I'm still seeing something like the failure in this PR when testing my revision if I search for Development.Module on my dev machine. What's strange is I don't see that when I search for Development.Module in a container set up for building manylinux wheels.

[mikeurbach]

@silvasean I think this should be good to pick up on the next integration with upstream. The confusion I had previously was related to a configuration with several external projects calling find_package(Python3 ...), where some asked for Development, and some asked for Development.Module. If everything asks for Development.Module, there shouldn't be any issue. Here's the CIRCT PR: llvm/circt#1977.

[silvasean]

@mikeurbach on chat I remember seeing some breakage related to this flying by, is this still the preferred pattern or is there a new recommended pattern?

[mikeurbach]

I think the main thing is to be consistent with how upstream MLIR calls find_package, and @stellaraccident added a helper for that: https://github.com/llvm/llvm-project/blob/c2f2c6b103bf6c481f937cbb5a44c721d416a3fe/mlir/CMakeLists.txt#L110. If you just call that, it should work. Let me know if not and I can try to help.

[silvasean]

Ok cool. Looks like Stella updated us. Will close this PR then.