Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optional recommendation arguments #113

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Optional recommendation arguments #113

merged 1 commit into from
Apr 23, 2020

Conversation

JakubTesarek
Copy link
Contributor

@JakubTesarek JakubTesarek commented Mar 29, 2020 •
edited
Loading

BC BREAK

@OndraM OndraM added this to the 2.0 milestone Mar 31, 2020
@OndraM OndraM changed the base branch from master to feature/boosting-rules March 31, 2020 12:09
@OndraM OndraM linked an issue Mar 31, 2020 that may be closed by this pull request
Optional UserRecommendation arguments #108
Closed
jirinovak
jirinovak reviewed Apr 6, 2020
View reviewed changes
Copy link
Member

@jirinovak jirinovak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VincTheSecond told me about this future change last week. I checked the changes to have better idea what it means for us in jobs.cz. I leave few typo comments and hope you don't mind 😄

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@OndraM OndraM changed the base branch from feature/boosting-rules to master April 9, 2020 15:19
@OndraM OndraM force-pushed the feature/optional-reccomendation-arguments branch from 97616d6 to 43a9492 Compare April 9, 2020 20:23
@OndraM
Copy link
Member

OndraM commented Apr 9, 2020

Rebased on current master (with merged boosting rules)

@OndraM OndraM force-pushed the feature/optional-reccomendation-arguments branch from 43a9492 to 87e1d4a Compare April 9, 2020 20:25
@OndraM OndraM changed the title Feature/optional recommendation arguments Optional recommendation arguments Apr 9, 2020
@ghost
Copy link

ghost commented Apr 9, 2020 •
edited by ghost
Loading

Fails
🚫 Backward incompatible changes detected

Backward incompatible changes introduced by this PR

  • [BC] The parameter $count of Lmc\Matej\Model\Command\UserRecommendation::create() changed from int to a non-contravariant string
  • [BC] The parameter $count of Lmc\Matej\Model\Command\UserRecommendation::create() changed from int to string
  • [BC] The return type of Lmc\Matej\Model\Command\UserRecommendation#setCount() changed from void to the non-covariant self
  • [BC] The return type of Lmc\Matej\Model\Command\UserRecommendation#setCount() changed from void to self
  • [BC] The return type of Lmc\Matej\Model\Command\UserRecommendation#setRotationRate() changed from void to the non-covariant self
  • [BC] The return type of Lmc\Matej\Model\Command\UserRecommendation#setRotationRate() changed from void to self
  • [BC] The return type of Lmc\Matej\Model\Command\UserRecommendation#setRotationTime() changed from void to the non-covariant self
  • [BC] The return type of Lmc\Matej\Model\Command\UserRecommendation#setRotationTime() changed from void to self

Generated by 🚫 dangerJS against 691ff99

OndraM
OndraM requested changes Apr 9, 2020
View reviewed changes
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
UPGRADE-3.0.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
src/Model/Command/UserRecommendation.php Outdated Show resolved Hide resolved
src/Model/Command/UserRecommendation.php Outdated Show resolved Hide resolved
src/Model/Command/UserRecommendation.php Outdated Show resolved Hide resolved
src/Model/Command/UserRecommendation.php Show resolved Hide resolved
tests/unit/Model/Command/UserRecommendationTest.php Outdated Show resolved Hide resolved
@JakubTesarek
Copy link
Contributor Author

Fixes implemented. @OndraM

OndraM
OndraM requested changes Apr 20, 2020
View reviewed changes
README.md Show resolved Hide resolved
src/Model/Command/UserRecommendation.php Outdated Show resolved Hide resolved
src/Model/Command/UserRecommendation.php Outdated Show resolved Hide resolved
@OndraM OndraM force-pushed the feature/optional-reccomendation-arguments branch from a7d03b3 to 691ff99 Compare April 23, 2020 17:32
@OndraM OndraM merged commit f07a0db into master Apr 23, 2020
@OndraM OndraM deleted the feature/optional-reccomendation-arguments branch May 14, 2020 12:11
@JakubTesarek JakubTesarek mentioned this pull request Sep 21, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jirinovak jirinovak jirinovak left review comments

@OndraM OndraM OndraM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0
Development

Successfully merging this pull request may close these issues.

Optional UserRecommendation arguments
3 participants
@JakubTesarek @OndraM @jirinovak