Fixed bug when recommendations were returned as strings. #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincTheSecond
previously approved these changes
Sep 23, 2020
OndraM
requested changes
Sep 23, 2020
What violations? I didn't get any violations locally and CI report is all green except one that ran out of memory. |
Yup, sorry, you are right - there are no errors in this run, however the codestyle check was not working properly (I already fixed in master), so it will report some issues once you rebase this branch with master and run |
JakubTesarek
force-pushed
the
fix-recommendation-response
branch
from
9673e15
to
55a9718
Compare
JakubTesarek
force-pushed
the
fix-recommendation-response
branch
from
55a9718
to
7ebb21b
Compare
OndraM
pushed a commit
to OndraM/matej-client-php
that referenced
this pull request
Dec 11, 2020
Fixed bug when recommendations were returned as strings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug caused by special behaviour of Matej.
When sending RecommendationCommand, Matej returns one of 2 types of responses. If the request or used scenario specifies item properties to get, it returns list of objects where there's always a field
item_idpresent. This is true even if the list of properties is empty.For backwards compatibility, Matej returns list of strings instead of objects if the request doesn't contain
item_propertiesfield and no scenario is used.When Matej collects fields to return, it first looks into the request and if there's no
item_propertiesfield, it looks into the configured scenario. In version 2.* matej-client-php used to always send this field so users never experienced this bug. in #113 we removed that argument and we send it only when user specifies item properties to get.This is a temporary bugfix until Matej unify the behaviour of the recommendation request. It will not be necessary afterwards.